is there a way to re-use the shadow-cljs server, and use the lein integration?

Rolled back to the version of shadow-cljs.edn that was working before, still getting the same behavior.

Getting weirder - running lein clean fixed the version without lein.

@dave.dixon socket connect failed, server process dead? means that the server was most likely killed forcefully so the server didn't clean up after itself. can you verify that the server is actually dead? ie. no running java process left?

lein clean will delete the target folder which includes target/shadow-cljs/*.port

the script uses those files to decide whether it should start a new server or connect to old one

I should add a command to delete those files

@lilactown re-use server? all commands works identically with or without lein

just don't run lein clean since that kills the information the server needs

or set :cache-root ".shadow-cljs" in your config so lein clean doesn't mess with the server state

which is a default I should probably change anyways

@hlolli not sure if i understand correctly but we run shadow-cljs like this:

(defn start-cljs-repl []
  (shadow-server/start!)
  (shadow/watch :app)
  (shadow/watch :test)
  (shadow/watch :devcards)
  (shadow/nrepl-select :app))

((nil . ((projectile-project-type . lein-test)
         (eval . (progn
                   (require 'cider)
                   (setq projectile-create-missing-test-files t)
                   (setq cider-cljs-lein-repl "(start-cljs-repl)"))))))

@mitchelkuijpers I think the issue is that you can't yet do this with node-repl

Ah ok nvm then

very neat! @mitchelkuijpers I'm stealing that for my non-node projects 🙂

I just pushed 2.2.0. bumped to 2.2 because I changed the default cache directory. it is now .shadow-cljs instead of target/shadow-cljs. too many conflicts with lein cleaning the target directory. you can configure the old directory by setting :cache-root "target/shadow-cljs" in your config.

(shadow.cljs.devtools.api/node-repl) also works inside nrepl now

also added shadow-cljs browser-repl (or (shadow.cljs.devtools.api/browser-repl) for a simple browser REPL without a build config

Tried updating to 2.2.0, still getting the issue where it immediately exits. Looking at the code it wasn't clear what would happen if cp/spawnSync failed before the process got started, i.e. if an error would be displayed. It seems like this is always failing for me, independent of lein, since it also failed to run an npm command it said it was executing.

Tried it as well. Now getting “cannot call a class as a function” error on an npm require. After a lein clean and downgrade back to 2.1.26, the issue disappears.

@levitanong your error is most likely related to https://github.com/google/closure-compiler/issues/2822

it should work if you add [com.google.javascript/closure-compiler-unshaded "v20180101"] to your dependencies

@dave.dixon just calling lein with-profile dev run -m shadow.cljs.devtools.cli --npm watch app directly also fails without any error?

No, directly calling the printed command works.

you are on windows with which node version?

I'm noticing, no matter how I kill shadow-cljs process within emacs the file nrepl.port isn't always deleted causing shadow-cljs - socket connect failed, server process dead?, I wonder if it's sending some kill signal that isn't handled by shadow-cljs?

no kill signals are handled by shadow-cljs since java doesn't support that

what does emacs do with the process?

Windows 10, node 8.9.4

I've tried two things (process-send-string (get-process "shadow-cljs") ":repl/quit\n") and (kill-process "shadow-cljs") it kills the process for sure, it may be sending some SIGTERM or SIGINIT, I wonder which or something else...

well, being a hacker, I can trigger emacs to delete these files on process kill...

are you sure the process is actually dead?

because the shadow-cljs process is the node process

it has a java child process

hmmm, I actually look for java, I wonder if my gnome-system-moniter isn't showing it, due to being nested within emacs...

but node should be able to listen to SIGTERM signals, so you can add some java process kill callbacks

@dave.dixon just reproduced the problem on my machine. I only ever started it via WSL bash so I never noticed it before

will look into it

@dave.dixon it seems to work with [email protected]

@thheller Had some weird problem getting node to update shadow-cljs, but once I got past that it worked. Thanks for the quick fix.