I just published 2.1.0 which might break your build if you were using relative requires. I did a rework on that to hopefully gain better support for working with local .js files. It might unintentionally present other bugs as well. Please try it.

https://shadow-cljs.github.io/docs/UsersGuide.html#_dealing_with_js_files

@hlolli you might be interested in this. I believe you were trying to deal with this a while ago (ie. use a .js file in a library jar)

@thheller perfect timing, I try it!

Is shadow-cljsjs 0.0.5 still valid? I'm getting react-15.5.4-0.jar deps.cljs refers to file not in jar: cljsjs/react/development/react.inc.js

thats an outdated cljsjs/react version. either exclude it or bump to a newer version

shadow-cljsjs has nothing to do with that

Ah, I figured thats where the deps.cljs was from

nope thats the cljsjs/react package itself

What would have changed? I'm not requiring react directly, just through reagent 0.7.0

CLJS itself does not validate deps.cljs files so "errors" in those files go unnoticed easily

shadow-cljs validates those files and checks if the contents are correct

in this case the jar file does not contain a file it is referring too

that error has been there for a long time

just add [reagent "0.7.0" :exclusions [cljsjs/react cljsjs/react-dom]] since we are not going to use them anyways

Yes, that makes sense. Why is it breaking all of a sudden though?

i.e. it worked yesterday

breaking? should just be a warning

oh wait did you upgrade to 2.1.0 and it is breaking now?

maybe I remove a try/catch accidentally

Oh, no, it's not a warning:

failed to start service
{:id :classpath}
ExceptionInfo: failed to start service
        clojure.core/ex-info (core.clj:4739)
        clojure.core/ex-info (core.clj:4739)
        shadow.runtime.services/start-many/fn--15833 (services.clj:135)
        shadow.runtime.services/start-many (services.clj:126)
        shadow.runtime.services/start-many (services.clj:105)
        shadow.runtime.services/start-all (services.clj:144)
        shadow.runtime.services/start-all (services.clj:139)
        shadow.cljs.devtools.server/start-system (server.clj:191)
Caused by:
/home/asp/.m2/repository/cljsjs/react/15.5.4-0/react-15.5.4-0.jar deps.cljs refers to file not in jar: cljsjs/react/development/react.inc.js
{:tag :shadow.build.classpath/deps-cljs, :source-path #object[java.io.File 0x64c82a3b "/home/asp/.m2/repository/cljsjs/react/15.5.4-0/react-15.5.4-0.jar"], :name "cljsjs/react/development/react.inc.js"}
ExceptionInfo: /home/asp/.m2/repository/cljsjs/react/15.5.4-0/react-15.5.4-0.jar deps.cljs refers to file not in jar: cljsjs/react/development/react.inc.js
        clojure.core/ex-info (core.clj:4739)
        clojure.core/ex-info (core.clj:4739)
        shadow.build.classpath/process-deps-cljs/get-index-rc--17183 (classpath.clj:252)
        shadow.build.classpath/process-deps-cljs/fn--17187 (classpath.clj:265)
        clojure.core/map-indexed/mapi--8189/fn--8190 (core.clj:7228)
        clojure.lang.LazySeq.sval (LazySeq.java:40)
        clojure.lang.LazySeq.seq (LazySeq.java:49)
        clojure.lang.RT.seq (RT.java:528)

Sorry, I could have been clearer 😉

but you upgraded to 2.1?

Yes

fixing, just a sec

add the exclusions if you don't want to wait 😉

Yup, works, thanks 🙂

oh, no, still errored out

just took longer

oh

re-frame probably

might be coming from a different dep now 😛

unfortunately basically all CLJS libs still expect to use cljsjs

yup

you can also add [cljsjs/react "15.6.2-4"] do your dependencies so you don't have to exclude it for everything

trying to figure out why it didn't error out previously

or rather why it errors out now .. the file is actually in the jar

@theasp fixed in 2.1.1. thanks for the report.

Awesome, thanks for the quick fix

Did someone try shadow-cljs for building react-native projects? Is there a sample project somewhere?

@mynomoto I did some very basic tests a while ago https://github.com/thheller/shadow-cljs-examples/tree/master/cljs-react-native-app

@thheller I will take a look, thanks!

"shadow-cljs": "^0.18.0" hehe cute 😛

should still work though

@tony.kay @thheller what the hell, these docs are awesome! https://shadow-cljs.github.io/docs/UsersGuide.html

@shaunlebron That is super weird timing. I was just writing this comment at the exact same time: “I finally drank two cups of coffee and read through the shadow-cljs guide. what a monumental project this is. I do not understand where you found the time.”

💯 haha, on the same wavelength. very excited to see the attention to detail on docs. very well written

@lee.justin.m i don’t get it either, thomas has been working on this for some 3-4 years

almost full time for the past 6 months or so, but yeah lots of work since dec 2013

i keep markdown notes to myself when i’m working through something complicated. you should see the file i wrote when trying to figure out JS import stuff based on the http://clojurescript.org docs. i really now wish i had gone with shadow first

yeah, thomas’s blog posts on importing js libraries are really good

@thheller awesome you took some time off to work on it, it really shows. let us know if you’re letting people support your work yet (patreon or whatever)

yeah still thinking about where I want to go with that. I still want to do so much more but can't really justify doing it since I need to get back to actual work soon.

i was in the same situation in november after taking 6 months on parinfer

the patreon stuff helps me treat the project as a part-time job to justify time spent

yeah. I still need to look into that properly. Last time I checked the tax situation for patreon in germany was weird.

is there a suggested way to run tests on Node.js for CI?