@mhuebert for react v16 and closure you need these externs I think

var ResponderEventPlugin;
var SimpleEventPlugin;
var TapEventPlugin;
var EnterLeaveEventPlugin;
var ChangeEventPlugin;
var SelectEventPlugin;
var BeforeInputEventPlugin;

but even when it compiles fine it doesn’t quite work, no event handlers ever trigger

CLJSJS has the latest externs

oh, I see. The top of the file says React 15.xx but it has been updated.

AFAICT only the plugins need externs for everything to compile properly

what is needed to work I don’t know

someone in #cljs-dev probably knows

I updated the externs in re-view to the latest from CLJSJS and now it compiles and runs for me. pushed the updated template.

uh nice

must have been some symbols related to event handling that were munged but did not cause errors..

yeah I just gave up but guess someone figured it out

I tried the externs before but must have missed something

good i can use this as a basis now

still getting the externs error on shadow’s closure build

the working cljsbuild :advanced base.js is 229,603 bytes

yeah I’ll fix the closure build

would seem it is not picking up the externs

still trying to fix source maps for :advanced when JS deps are used. can’t quite figure it out.

does shadow support the :preloads compiler option?

looks like yes, seeing examples.

ah, but it’s in :devtools not :compiler-options

yeah since its a dev only thing

makes a lot of sense to have it in :devtools

have you ever tried to require “d3”?

I think so yes

doesn’t work with :closure IIRC

what the heck?

ns or shadow_re_frame/provide_js_deps.cljs?

ok got the error as well with just "d3"

whoops

https://github.com/mhuebert/shadow-re-frame

fixed in [email protected]

this is the repo. shadow-re-frame/provide-js-deps + the :resolve options in shadow-cljs.edn are a workaround to use libs that require cljsjs stuff

🙂

uhm what?

was getting cljsjs... not provided errors

right

https://code.thheller.com/blog/shadow-cljs/2017/09/15/js-dependencies-going-forward.html

see BREAKING CHANGE: Removing :foreign-libs support

but i don’t have control over those libraries. so I require the same deps from node_modules in the provide-js-deps namespace and set the global var that the lib expects

hmm right

but you are really abusing the system here, thats not a good idea

also use (js/goog.exportSymbol "React" react) not the set!

but the dummy cljsjs/react.cljs file really is a better option than resolve

but putting that into a library might not be a good idea 😞

I don’t think there is any good option because non-shadow build tools have no way to include libs that are not Closure compatible except via foreign libs?

in that case I can’t submit a PR to these libs

well the same way reagent fixed it in the alpha version

but React is closure compatible

no idea if d3 is

uhm yeah that part is not clear to me either

but react also works via :foreign-libs not just closure

{:foreign-libs
 [{:file "cljsjs/react/development/react.inc.js",
   :provides ["react" "cljsjs.react"],
   :file-min "cljsjs/react/production/react.min.inc.js",
   :global-exports {react React}}],
 :externs ["cljsjs/react/common/react.ext.js"]}

this is the cljsjs/react deps.cljs

I think that it will use the :foreign-lib if node_modules/react doesn’t exist

I honestly don’t know … I couldn’t figure it out from reading the CLJS code

but it is possible to compile without closure while still using (:require [react])

right. so if d3 would add :global-exports to cljsjs then maybe it works. i wonder if, given the “react” in :provides, the react in :global-exports is redundant?

I have no idea really, it seemed confusing to me which is why I did the :resolve thing

granted it solves a different problem

d3 is also one of those packages that is actually split into many packages

I’m open to ideas … I might just re-enable foreign-libs as a last resort but I really don’t want to 😞

the potential for conflicts is just too high

so this hack doesn’t work, in the end, because the :resolve stuff mapping cljsjs.* to global vars runs before the global var is defined

yeah it is not a pretty sight.

(ns cljsjs.d3
  (:require ["d3" :as d3]))

(js/goog.exportSymbol "d3" d3)

I might just create a bunch of those and create a shadow-cljs-foreign-libs package or so

am getting this:

shadow.js.provide("module$cljsjs_d3", function(global,require,module,exports) {
module.exports=(d3);
});

errors out because d3 has not been defined

@mhuebert you can get rid of a bunch of closure warnings by setting :compiler-options {:closure-warnings {:global-this :off}}

got the :closure compile working again

i haven’t looked at blessed before, this looks interesting

ok closure works fine again … until you want custom :resolve … not sure how I bring that into Closure yet

hmm.

The required namespace "cljsjs.react.dom.server" is not available, it was required by "reagent/dom/server.cljs".

was trying to test with shadow-re-frame

tested with lein new re-view instead, works after bumping re-view to 0.4.6

base.js (233722 bytes) closure vs shadow base.js (259810 bytes)

not a huge difference after gzip but when it works closure is definitely better

Uhg ok I'll fix in a bit

updated template to 0.4.6 (keep forgetting to update both project.clj and shadow-cljs.edn)

I could parameterize the version

since the template stuff already makes that easy

latest shadow-re-frame should work

i was switching to some older versions of reagent while trying to get re-frame-trace to work. had to patch it to work with react 16.

shadow-re-frame is compiling for me with closure but i’ve got externs problems again

no externs problems with :release using shadow as js provider, but with closure, EventPluginRegistry: Cannot inject event plugins that do not exist in the plugin ordering, mk`.` again

user-options at command line: https://github.com/SBoudrias/Inquirer.js (less complex than a full-blown view layer -- this is what firebase-tools uses)