2022-10-18 scittle | Clojure Slack Archive

scittle

craftybones 2022-10-18T02:55:32.279209Z

@borkdude - on scittle.nrepl there's some code that checks to see if SCITTLE_NREPL_WEBSOCKET_PORT is set and if so it sets the ws_nrepl variable. https://github.com/babashka/scittle/blob/12e5a33964e0dd8feba8537c62867abb3aa5e81a/src/scittle/nrepl.cljs#L34

craftybones 2022-10-18T02:56:46.300669Z

shouldn't

(new js/WebSocket "")

(new js/WebSocket (str ":" (.-SCITTLE_NREPL_WEBSOCKET_PORT js/window) "/_nrepl")

craftybones 2022-10-18T02:57:26.696189Z

That port var isn't getting used anywhere else

craftybones 2022-10-18T02:58:21.515239Z

I'm not running it, just browsing through and it seemed wrong

borkdude 2022-10-18T09:43:37.163499Z

maybe yes

borkdude 2022-10-18T09:43:47.057039Z

please try it out and submit a PR if it turns out to be true

craftybones 2022-10-18T13:37:30.983979Z

I've confirmed that it is broken and I've fixed it. However, I have a question. For the example to be fixed, a dist needs to be pushed with potentially a version bump. So this is going to have to happen in two stages. First a PR to merge the changes and generate a dist. Then once that dist is pushed to CDN, change the example to reflect the correct version. Is that fine?

borkdude 2022-10-18T13:44:20.165269Z

sure

craftybones 2022-10-18T14:10:37.223679Z

I've raised a PR. https://github.com/babashka/scittle/pull/45

craftybones 2022-10-18T14:10:42.249629Z

Kindly approve.

borkdude 2022-10-18T14:14:19.861929Z

Two comments

craftybones 2022-10-18T14:34:32.774579Z

I've made the relevant changes. Used a when-let and tested it in prod and dev mode.

craftybones 2022-10-18T14:34:42.541039Z

I've removed the deref as well.

borkdude 2022-10-18T14:37:12.959809Z

Thanks!

borkdude 2022-10-18T14:43:50.238839Z

Can you also update the changelog?

borkdude 2022-10-18T14:44:18.494039Z

Under the "Unreleased" section would be good

craftybones 2022-10-18T14:44:26.658629Z

Sure

craftybones 2022-10-18T14:44:49.405949Z

Is there an unreleased section or do I just tack it on in the top?

craftybones 2022-10-18T14:53:05.758259Z

Added

craftybones 2022-10-18T15:32:09.137279Z

Thanks @borkdude

borkdude 2022-10-18T15:34:01.999249Z

Likewise

Clojurians Log v2

scittle