I get warnings compiling Joyride with latest sci.configs dd872bab0ff07f98a3ee99a992d2fbef5fdbf24c.
[:extension] Build completed. (221 files, 220 compiled, 3 warnings, 3.91s)
------ WARNING #1 - :fn-arity --------------------------------------------------
File: /Users/pez/.gitlibs/libs/org.babashka/sci.configs/dd872bab0ff07f98a3ee99a992d2fbef5fdbf24c/src/sci/configs/cljs/test.cljs:936:17
--------------------------------------------------------------------------------
933 | (fn [[ns vars]]
934 | (fn []
935 | (let [ns (symbol (str ns))
936 | ni (sci-namespaces/sci-ns-interns (store/get-ctx) ns)
-----------------------^--------------------------------------------------------
Wrong number of args (2) passed to sci.impl.namespaces/sci-ns-interns
--------------------------------------------------------------------------------
937 | _ (when-let [fs (get ni 'cljs-test-once-fixtures)]
938 | (update-current-env! [:once-fixtures] assoc ns
939 | @fs))
940 | _ (when-let [fs (get ni 'cljs-test-each-fixtures)]
--------------------------------------------------------------------------------
------ WARNING #2 - :fn-arity --------------------------------------------------
File: /Users/pez/.gitlibs/libs/org.babashka/sci.configs/dd872bab0ff07f98a3ee99a992d2fbef5fdbf24c/src/sci/configs/cljs/test.cljs:981:13
--------------------------------------------------------------------------------
978 | (defn test-all-vars-block
979 | ([ns]
980 | (let [env (get-current-env)
981 | ni (sci-namespaces/sci-ns-interns (store/get-ctx) ns)]
-------------------^------------------------------------------------------------
Wrong number of args (2) passed to sci.impl.namespaces/sci-ns-interns
--------------------------------------------------------------------------------
982 | (concat
983 | [(fn []
984 | (when (nil? env)
985 | (set-env! (empty-env)))
--------------------------------------------------------------------------------
------ WARNING #3 - :fn-arity --------------------------------------------------
File: /Users/pez/.gitlibs/libs/org.babashka/sci.configs/dd872bab0ff07f98a3ee99a992d2fbef5fdbf24c/src/sci/configs/cljs/test.cljs:993:25
--------------------------------------------------------------------------------
990 | (update-current-env! [:each-fixtures] assoc ns
991 | @fs)))]
992 | (test-vars-block
993 | (let [vars (vals (sci-namespaces/sci-ns-interns (store/get-ctx) ns))
-------------------------------^------------------------------------------------
Wrong number of args (2) passed to sci.impl.namespaces/sci-ns-interns
--------------------------------------------------------------------------------
994 | tests (filter (fn [var] (:test (meta var))) vars)
995 | sorted (sort-by (fn [var] (:line (meta var))) tests)]
996 | sorted))
997 | [(fn []
--------------------------------------------------------------------------------
I’m also using sci 0.10.46. The warnings are from tests, but also it’s about sending in ctx instead of sci-ns, so I’m thinking I need to pay attention 😃I’ll have a look tonight
I also get errors trying to add replicant.string
The required namespace "replicant.alias" is not available, it was required by "sci/configs/cjohansen/replicant.cljs".
But it could well be wrong-holding from my side.you should use the absolutely newest SCI. if you want to use replicant with sci.configs you should add the replicant dependency
let me bump the sci.configs tests with the newest sci. it's already using the almost newest (the commit before the mvn version)
oh crap I didn't push that?
merged,should work now
I released a new Joyride without bumping any dependencies. I guess that’s good, now I can get it on latest sci and stuff separately.
yeah testing would be good
Haha, that too!