Clojurians Log v2
Clojure programming
Channels
Apps
sci
2023-08-15T17:28:48.043329Z
Continuing what I started with tests, https://github.com/babashka/sci.configs/blob/64342798713d355244d86ee6c311725d0c58e682/src/sci/configs/cljs/test.cljs#L1077, it doesn't seem like that is working as expected. The raw all-ns value is:
"gracie.projects2" "cljs-bean.core" "tests.cli" "user" "promesa.protocols" "nbb.core" "promesa.core" "nbb.classpath" "edamame.core" "framework.env" "cljs.test" "goog.object" "babashka.cli" "clojure.core" "clojure.set" "framework.queue" "cljs.pprint" "clojure.main" "nbb.error" "gracie.queue" "clojure.edn" "notion.api" "tests.gracie.test-queue" "clojure.repl" "clojure.string" "framework.utils" "sci.core" "cljs.reader" "clojure.walk" "clojure.template")(t/run-all-tests #"tests\.gracie") should match tests.gracie.test-queue
2023-08-15T17:29:52.489399Z
However, that always returns an empty list. That can be reproduced in the repl by manually filtering the results of (all-ns)
2023-08-15T17:30:03.061439Z
If I replace re-matches with re-find, then it works
borkdude 2023-08-15T17:32:54.756969Z
this code comes from here: https://github.com/clojure/clojurescript/blob/0a5f5edcc1c00eecceb6d32c478e66083a30503b/src/main/cljs/cljs/test.cljc#L334
2023-08-15T17:34:09.371709Z
Interesting!
borkdude 2023-08-15T17:34:45.030319Z
I don't think your PR is the correct one either
borkdude 2023-08-15T17:35:01.188909Z
It's better to test nbb in combination of sci.configs with :local/root checkout
borkdude 2023-08-15T17:35:46.711359Z
I think (all-ns) should be (map str (keys (all-ns))) and then just apply re-matches over those strings
borkdude 2023-08-15T17:35:55.935379Z
PR welcome, if you can verify that this works
borkdude 2023-08-15T17:36:01.874719Z
else I'll do it tomorrow
2023-08-15T17:41:48.499379Z
Actually it might be working, seems re-matches requires the pattern to match the full string
2023-08-15T17:44:59.874409Z
Yes! That was it, it’s working correctly now with a pattern that matches the full string
borkdude 2023-08-15T17:47:01.694239Z
ah right
borkdude 2023-08-15T17:47:05.795419Z
good to know :)
👍 1