Fork me on GitHub
#sci
<
2022-06-23
>
ikitommi09:06:58

sci 0.3.5 seems to have dropped default binding for str. noticed when bumping up deps on malli, so:

;; works on 0.3.4, not on 0.3.5
(require '[sci.core :as sci])
(sci/eval-string "(str/upper-case \"kikka\")")
Is this intentional? don’t see it on the https://github.com/babashka/sci/blob/master/CHANGELOG.md#v035. :thinking_face:

ikitommi09:06:33

I can easily change the transformation docs & tests to use something else, but would like to document this to Malli CHANGELOG too.

borkdude09:06:31

Yes, it was intentional. Having the default str alias in the user namespace can be configured with:

{:aliases {'str 'clojure.string}}

borkdude09:06:42

Not sure where I removed it anymore

borkdude09:06:38

I think the default configuration of SCI should be unopiniated, which was basically the reason

ikitommi10:06:20

That’s a good call. I first ported all examples to use the long form but the examples looked bad and added the alias into malli-sci default config. thanks!

👍 1
borkdude12:06:19

Shaving off some size of the advanced compiled output: a 160kb win.

🎉 2
❤️ 1
borkdude12:06:57

(but now self-hosted CLJS is unhappy..)

haywood13:06:14

kinda wild, but using (or) with 20 clauses doesn’t work but 19 does in my SCI compiler

haywood13:06:52

(or
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  ;nil
  true)
=> true

haywood13:06:04

(or
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  nil
  true)
=> nil

borkdude13:06:35

Is this JVM or CLJS?

borkdude13:06:53

issue welcome

haywood13:06:12

+1 let me confirm I can repro

haywood13:06:23

oh nice, I’ll open an issue

borkdude13:06:06

found the issue

💥 1
borkdude14:06:45

Pushed the fix

borkdude14:06:53

Did you solve your issue with clojure.test the other day?

haywood14:06:48

yea! way to remember. ended up being a mixture of clojure.test parallelization pain

haywood14:06:07

what I ended up with was a redefs.clj namespace, and a macro that does all the things necessary to make clojure.test run in isolation

haywood14:06:27

it just took a bit of trial and error to get the magic recipe, thank you so much again!

haywood14:06:47

will this be autodeployed? should I monitor this page https://clojars.org/org.babashka/sci

borkdude14:06:57

you're not using git deps I assume?

borkdude14:06:15

I can do another mvn release

haywood14:06:28

🙏:skin-tone-2:

borkdude14:06:11

Will do in about 30 minutes

haywood14:06:18

thank you!

raymcdermott14:06:17

30 minutes? What happened to customer service? SMH

haywood14:06:29

Truly a remarkable individual, cant even come close to overstating it

💯 1
borkdude14:06:04

0.3.32

gratitude-thank-you 2
😍 1