Fork me on GitHub
#sci
<
2022-02-05
>
baibhavbista14:02:23

hey folks, previously (0.2.1) when passing cljs values to js functions from sci, they would automatically be converted to js objects. This does not seem to be the case now (0.2.8). I'm curious if this change was intentional (maybe for perf benefits?) or a regression.

baibhavbista14:02:00

I only noticed this because some scripts which seemed to be taking advantage of this in sci broke 😅

borkdude14:02:06

@U0154QR3DC7 It was actually a bug that it converted those JS values, that shouldn't have happened and was now fixed

baibhavbista14:02:07

Thanks for the super quick response @U04V15CAJ You're the best 😁

❤️ 1
baibhavbista14:02:24

as an aside, in which version was that fix introduced?

baibhavbista14:02:20

yeah, thenks 😄

borkdude14:02:57

There were a lot of improvements with JS interop in 0.2.7-0.2.8

1
borkdude14:02:14

If I may ask, what are you using SCI for?

baibhavbista14:02:39

oh, I work at RoamResearch and we use sci for running user's js and cljs scripts 😁

baibhavbista14:02:53

I believe you've talked with Conor White Sullivan, our CEO?

borkdude14:02:30

Cool! Yeah, we've spoken on Twitter

❤️ 1
borkdude14:02:36

If you want, you can post something here: https://github.com/babashka/sci/discussions/662

👍 1
borkdude14:02:58

Say hi to Conor from me.

❤️ 1
borkdude14:02:48

If you're using SCI at your company or on a side project, you're welcome to share here: https://github.com/babashka/sci/discussions/662