In lack of an #edamame channel. When I try the README example:

(parse-string "#(* % %1 %2)" {:fn true})
;;=> (fn [%1 %2] (* %1 %1 %2))

(fn*
 [%1 %2]
 (* %1 %1 %2))

ah it should be fn* actually, this was changed at some point to be more like the original

so the README should be changed

Too bad =(

why?

My use case is translating tests from 4Clojure and I would like them to not use the rather confusing fn*. But it is just my use case so probably not something that should direct the development of edamame.

user=> (e/parse-string "#(+ 1 2 3)" {:fn true :postprocess (fn [{:keys [obj]}] (if (and (seq? obj) (= 'fn* (first obj))) (list* 'fn (rest obj)) obj))})
(fn [] (+ 1 2 3))

^ @pez

I'm getting an Exception when trying to evaluate a defrecord that implements protocols that were defined outside of sci Example defrecord:

(defrecord
    My-comp
    [extra context]
    membrane.ui/IBounds
    (-bounds
      [this__25094__auto__]
      (:membrane.component/bounds this__25094__auto__)))

@smith.adriane protocols need a bit of special attention in sci. Internally they are piggy-backing on multi-methods (since multi-methods don't need any compilation, but protocols do).

I can show you how you can have a protocol outside of sci and inside sci, I have several examples of that

lemme check

@smith.adriane Note that this is quite "implementation" detail-ish, but here you go: https://github.com/borkdude/sci/blob/master/src/sci/impl/core_protocols.cljc IDeref, etc is implemented as a protocol in SCI and also outside of SCI (in CLJS, but in CLJ it's an interface)

I'll also dig up another example that's only in bb

awesome!

here's the Coercions protocol impl from : https://github.com/babashka/babashka/blob/2282b2922d2588599e9c2fd7b2096cc365c15bf5/src/babashka/impl/clojure/java/io.clj#L56

something like this:

(defmethod as-file :default [x]
  (io/as-file x))

while inside sci the multimethod "wrapper" is being called

I should perhaps one day expose and document this better, but so far nobody ever asked for it :)

The :postprocess trick works perfectly! Thanks!

Is this a bug?

(edamame/parse-string "#{'(:x) '(:y)}")
; Execution error (ExceptionInfo) at edamame.impl.parser/throw-reader (parser.cljc:102).
; Set literal contains duplicate key: '

hm, it looks like it? issue welcome!

oh no wait, I get it :)

you should allow :quote as well

else it gets parsed as EDN

and single quotes are just standalone elements in EDN

^ @pez

Basically what you are seeing here is similar to:

user=> (clojure.edn/read-string "#{'(:x) '(:y)}")
Execution error (IllegalArgumentException) at user/eval1 (REPL:1).
Duplicate key: '

if you want to allow all code features, you can just use :all true