Fork me on GitHub
#rum
<
2020-04-29
>
robert-stuttaford09:04:11

hey @roman01la! on 12-SNAPSHOT if we have a bunch of sablono calls, can we keep it like that while also removing the explicit sablono deps we have? or would we have to update nses? we use these three sablono fns:

sablono.interpreter/attributes
sablono.interpreter/interpret
sablono.interpreter/interpret-seq

roman01la09:04:59

@robert-stuttaford Hey! I've forked Sablono and renamed it to daiquiri, changing the name should be enough.

robert-stuttaford09:04:50

ok! and we'd need to do that for 12-SNAPSHOT testing to succeed?

roman01la09:04:06

yep, that is correct

robert-stuttaford09:04:30

ok. so s/sablono/daiquiri + bump version, then test everything and report back, got it 👍

robert-stuttaford09:04:58

ofc ! thanks for making Rum better man

roman01la09:04:40

My pleasure. How's 0.11.5, did it work fine for you?

robert-stuttaford09:04:59

it worked completely fine, i just only tested it after you released it 🙂

robert-stuttaford09:04:28

we're one of those lucky businesses that got busier due to the pandemic (online adult learning) so we've been a tad bit... busy

roman01la09:04:27

Lucky you indeed!