Fork me on GitHub
#rum
<
2020-04-15
>
roman01la11:04:54

Release candidate with a bunch of fixes and new stuff https://github.com/tonsky/rum/blob/gh-pages/CHANGELOG.md#0115-snapshot Give it a try on your projects and report any issues in the repo 0.11.5-SNAPSHOT

serioga13:04:13

My project works. Maybe Warning: Text content did not match. differs but not sure.

serioga13:04:57

> Maybe Warning: Text content did not match. no, same warnings in release version, so no difference.

serioga12:04:23

can it be released in SNAPSHOT?

roman01la12:04:30

@serioga I should ask Nikita to push a release to Clojars, but git deps is easier for me, since it doesn't require anything. Is there a way to test things locally for you?

serioga12:04:32

not sure if I'm ready to do something harder than changing version in project.clj 🙂

roman01la12:04:25

yeah that's fine

serioga13:04:41

@roman01la why react 16.8.6-0? I use 16.13.0-0 without problem.

roman01la13:04:39

we are gonna move gradually

serioga13:04:38

@roman01la should I try snapshot with recent libs as well?

roman01la13:04:47

Ideally you'd use 16.8.6-0, but any other newer version should be fine I think

serioga13:04:38

I see warnings

Warning: componentWillMount has been renamed, and is not recommended for use. See  for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: player-search react-dom.inc.js:82:32
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See  for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: 
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: player-search, wrapped-input
is it solvable?

roman01la13:04:33

is that on 16.13.0-0?

serioga13:04:41

> is that on 16.13.0-0? no. With your dependencies.

serioga13:04:30

I see these warnings since long time ago

roman01la13:04:38

yeah, those are deprecations

roman01la13:04:46

not a problem for now

serioga13:04:11

so no solution for this deprecations at the moment?

roman01la13:04:36

Is that related to JVM SSR?

serioga13:04:06

> Is that related to JVM SSR? yes, I generate code on server and hydrate. sometimes there are differences.