Hi I'm trying to implement a copy operation for an API. We've decided to implement it as something like POST /myresource?sourceresourceid=x with no body. I first tried creating a separate (POST) macro and that didn't work in terms of it showing up in the Swagger page as another entry. i've also tried just adding a :query-param to the existing (POST "/myresource"..) but the query param doesn't show up in the existing definition when I do that either. Is this supported?

@eoliphant hi. not sure about the question, but this works:

(def app
  (api
    {:swagger
     {:ui "/"
      :spec "/swagger.json"}}

    (POST "/my-resource" []
      :query-params [sourceresourceid :- s/Str]
      (ok {:id sourceresourceid}))))

Hi @ikitommi, indeed it does. I think I'd been working too long without a break and totally missed that it'd showed up lol. My original question was around doing something like the following

(POST "/my-resource" []
      :query-params [sourceresourceid :- s/Str]
      (ok {:id sourceresourceid}))

(POST "/my-resource" []
      :body [something Something]
      (ok ))

For example I have the following:

(POST "/roles" []
      :query-params [sourceroleid :- String]
      :summary "Copy a  role"
      (ok))
    (POST "/roles" []
      :body [role roleEntry]
      :summary "Add a new role"
      (let [retval (r/add-role role)]
        (if (f/failed? retval)
          (bad-request {:message (f/message retval)})
          (created "/role" role))))

(POST "/roles" []
      :body [role roleEntry]
      :query-params [sourceroleid :- String]
      :summary "Add a new role"
      (let [retval (r/add-role role)]
        (if (f/failed? retval)
          (bad-request {:message (f/message retval)})
          (created "/role" role))))

@eoliphant We've used an empty body for PUT before:

(PUT "/" request
                      :name :update-foo
                      :summary "Update a foo"
                      :return {:data {}}
                      (do ...))

When called, clients often pass "" (an empty string) as the HTTP body

you might try that with a POST as well

Hmm, but is that going to work in my case. Since if it's truly a new one, then I want a valid JSON, if not then I want nothing (or an empty string, etc) and expect to see the sourceroleid param. Wouldn't the body validation fail in that case?

also, SN, do you know how to specify an optional :query-param? like if I have :query-param [a :- String, b :- String] but b isn't required. It's pretty straightforward in the (defschemas) but i'm not seeing how to do in in this case

hi all I’m trying to build rest api with compojure-api I have the following definition:

(context "/api" []
      :coercion :spec

      (POST "/decision" []
        :return string?
        :body [body string?]
        (ok
          {:foo body}))

...)

when I do :

curl -0 -v POST  \
-H 'Content-Type: text/json; charset=utf-8' \
-d @- << EOF
"foo"
EOF

I get:

{
    "spec": "(spec-tools.core/spec {:spec clojure.core/string?, :type :string})",
    "problems": [
        {
            "path": [],
            "pred": "clojure.core/string?",
            "val": null,
            "via": [],
            "in": []
        }
    ],
    "type": "compojure.api.exception/request-validation",
    "coercion": "spec",
    "value": null,
    "in": [
        "request",
        "body-params"
    ]
}

it looks like it expects body-params in request but there is no such key

this is the function which throws the exception

compojure.api.coercion/coerce-request!

(defn coerce-request! [model in type keywordize? open? request]
  (let [transform (if keywordize? walk/keywordize-keys identity)
        value (transform (in request))]
    (if-let [coercion (-> request
                          (get-request-coercion)
                          (resolve-coercion))]
      (let [model (if open? (cc/make-open coercion model) model)
            format (some-> request :muuntaja/request :format)
            result (cc/coerce-request coercion model value type format request)]
        (if (instance? CoercionError result)
          (throw (ex-info
                   (str "Request validation failed: " (pr-str result))
                   (merge
                     (into {} result)
                     {:type ::ex/request-validation
                      :coercion coercion
                      :value value
                      :in [:request in]
                      :request request})))
          result))
      value)))

where in is :body-params

how can I make compojure-api to to bind the passed body to the declared variable in handler?

@ikitommi any ideas ? ^

even sticking to schema it seems my body is nil

(POST "/decision" []
        :return s/Str
        :body [body s/Str]
        (ok
          (foo body)))

{
    "schema": "java.lang.String",
    "errors": "(not (instance? java.lang.String nil))",
    "type": "compojure.api.exception/request-validation",
    "coercion": "schema",
    "value": null,
    "in": [
        "request",
        "body-params"
    ]
}

what do I need to do to get POST data bind to body ?