rewrite-clj

ericdallo 2025-03-31T10:54:57.756009Z

@lee can we have a new release of rewrite-clj with the recent additions?

ericdallo 2025-03-31T10:55:46.060019Z

the main issue is that although we are using by git sha on clojure-lsp, there is lein-clojure-lsp which is a lein project, and with pedantic we are have version issues on clients, so we can't specify the rewrite-clj version to use there

lread 2025-03-31T11:08:07.610589Z

I’ve been busy working on other projects. I’m not keen to release paredit changes in their current state. I’ll make it a priority to get back to paredit soon.

👍 1
borkdude 2025-03-31T15:26:27.921009Z

> I’m not keen to release paredit changes in their current state Why did you merge them?

🤨 1
lread 2025-03-31T17:01:04.344229Z

?

lread 2025-03-31T17:01:27.135939Z

To make them easily available for folks to experiment with.

👍 1
lread 2025-03-31T17:02:40.140749Z

Paredit has been a huge effort to rework. I keep learning new things as I fix things.

lread 2025-03-31T17:04:13.109999Z

It's been interesting, but after a while, it's not a ton of fun. Hence, me taking a break to work on other things.

ericdallo 2025-03-31T17:04:26.652489Z

What you did recently on master really helped clojure-lsp fix their bugs and looks stable from LSP POV

❤️ 1
borkdude 2025-03-31T17:07:08.831429Z

If things didn’t get worse then I guess it’s safe to do a release

lread 2025-03-31T17:07:31.897759Z

I'm not keen to release because as I rework paredit more behavior could still change and I'd love to not to create breaking changes.

👍 1
lread 2025-03-31T17:09:15.220119Z

If I had realized paredit was going to be so much work, I suppose I could have done the work in a branch off master. But this realization did not hit me early enough.

borkdude 2025-03-31T17:40:07.788579Z

Are the changes that @ericdallo is interested in the paredit ones?

lread 2025-03-31T17:40:51.087999Z

Yep

borkdude 2025-03-31T17:41:05.776039Z

Got it.

borkdude 2025-03-31T17:42:03.777949Z

What if a critical bug came up, we’d fix it and had to release it today?

lread 2025-03-31T17:42:58.986159Z

Not ideal, but I'd have to make a choice. Could revert paredit changes and release. Or release paredit as is and pay the price later.

ericdallo 2025-03-31T17:44:22.088509Z

AFAIK the paredit changes were add new functions right? so looks safe to me

lread 2025-03-31T17:44:29.665439Z

Open source is not always a fun hobby!

lread 2025-03-31T17:46:27.339229Z

Yeah, but I'm not confident I won't create breaking behaviour changes in paredit... I've learned that I don't fully understand what paredit should be doing yet in some cases.

lread 2025-03-31T17:47:34.880639Z

Once I get a grip on that, I'll feel better about creating a release.

👍 1
lread 2025-03-31T17:48:58.355389Z

Which means... I'm dragging myself back to paredit to try to finish it up enough for a release.

borkdude 2025-03-31T17:59:34.453089Z

I guess worse case we could’ve released an alpha ;)

lread 2025-03-31T18:00:53.803269Z

Yeah... I suppose... mark paredit changes as experimental and prone to change... use at your own risk... etc...

ericdallo 2025-03-31T18:01:37.104419Z

I'd buy that :)

lread 2025-03-31T18:04:31.008279Z

Ha! If I bog down too much, we'll do that. But give me some more days and I'll see what I can do.

ericdallo 2025-03-31T18:07:35.890039Z

no problem, thanks for your time!