rewrite-clj

lread 2022-05-27T15:44:07.222899Z

@ivar.refsdal I https://github.com/clj-commons/rewrite-clj/commit/04e7f0f3d1746b93c4bd5d1dd5f2979e4d75885f, seems all good to me, but are you able to give it a whirl for me?

Ivar Refsdal 2022-05-31T17:13:14.980079Z

Hi @lee Sorry about the delay. The commit 04e7f0f3d1746b93c4bd5d1dd5f2979e4d75885f looks good to me! I've added a tag 0.1.33 now: https://github.com/ivarref/gen-fn/releases/tag/0.1.33 The tests still pass using the master commit. Thanks and kind regards!

lread 2022-05-31T17:15:47.195089Z

Thanks for following up @ivar.refsdal! I’ll add gen-fn to canary testing and cut a new release of rewrite-clj soon.

🚀 1
lread 2022-05-27T19:11:47.169889Z

@ivar.refsdal I was about to add gen-fn to the rewrite-clj canary test suite, but I see that its git repo is not version tagged. If you add a version tag (ex. 0.1.33 or v0.1.33) I can find the source related to a release and run your tests using rewrite-clj master.

lread 2022-06-08T13:46:44.425309Z

@ivar.refsdal hmm… just tried to run gen-fn tests:

❯ clojure -M:test
Error building classpath. Could not find artifact com.datomic:datomic-pro:jar:1.0.6397 in central ()
Maybe not a good candidate for rewrite-clj canary testing then?

Ivar Refsdal 2022-06-08T17:23:17.480989Z

Ah, I didn't think about that. Yes, maybe not the best candidate then unfortunately.

👍 1
Ivar Refsdal 2022-06-08T17:27:17.345289Z

If you (and everybody else that wants to run the canary tests) is a registered Datomic user (free, IIRC), then you may configure your ~/.m2/settings.xml to handle this:

...
  <servers>
    …
    <server>
      <id></id>
      <username>user@example.com</username>
      <password>pass</password>
    </server>
    …
  </servers>
  ...

Ivar Refsdal 2022-06-08T17:27:58.977989Z

But yes this setup is a hassle IMHO, so probably best to leave it out as a requirement for running a test suite...

lread 2022-06-08T17:29:09.989299Z

Good to know! I probably won’t set that up for rewrite-clj canary testing tho….

👍 1