Clojurians Log v2

Thanks for following up, and looking forward to a fix in the future 🙂

@ivar.refsdal Ok I’ll start with rerunning your example from a plain old clj repl.

user=> (require '[rewrite-clj.zip :as z])
nil
user=> (-> (z/of-string "{}") (z/assoc :demo "string-value"))
[<map: {:demo "string-value"}> {:l [], :pnodes [<forms: {}>], :ppath nil, :r nil, :changed? true}]
user=> (-> (z/of-string "{}") (z/assoc :demo "\"quoted\""))
[<map: {:demo ""quoted""}> {:l [], :pnodes [<forms: {}>], :ppath nil, :r nil, :changed? true}]
user=> (-> (z/of-string "{:demo \"\\\"quoted\\\"\" }"))
[<map: {:demo "\"quoted\"" }> {:l [], :pnodes [<forms: {:demo "\"quoted\"" }>], :ppath nil, :r nil}]

I’m gonna guess something formatted your output weird and that we are on the same page.

So, I think maybe the issue is that you are expecting strings to the same as reading from a file?

The string "string-value" is internally the string string-value The string "\"quote\"" is internally the string "quoted" And those are what will be seen by rewrite-clj.

I could be entirely missing your question though, lemme know if that makes any sense.

You are right in that the formatted output is weird in some way. It also works on the console for me (but not in IntelliJ/Cursive). However, here is a related problem (?)/thing I don't understand:

(-> "{}" z/of-string (z/assoc :demo "here is a quote:\". End.") (z/root-string))
=> "{:demo \"here is a quote:\". End.\"}"

(-> zloc-desc (z/replace "My first Project.") z/root-string println)

(-> zloc-desc (z/replace "Project with a quote: \". A quote.") z/root-string println)

(defproject my-project "0.1.0-SNAPSHOT"
              :description "Project with a quote: ". A quote.")

Thanks for your time and reply 🙂

1.0.767-alpha does not do it properly (I think!):

$ clj -Sdeps '{:deps {rewrite-clj/rewrite-clj {:mvn/version "1.0.767-alpha"}}}' -e '(do
(require (quote [rewrite-clj.zip :as z])) 
(-> (z/of-string "{}") 
    (z/assoc :demo "and a quote: \". <- A quote.")
    (z/root-string)
    (println))
)'
WARNING: Implicit use of clojure.main with options is deprecated, use -M
{:demo "and a quote: ". <- A quote."}

$ clj -Sdeps '{:deps {rewrite-clj/rewrite-clj {:mvn/version "0.6.1"}}}' -e '(do
(require (quote [rewrite-clj.zip :as z])) 
(-> (z/of-string "{}") 
    (z/assoc :demo "and a quote: \". <- A quote.")
    (z/root-string)
    (println))
)'
WARNING: Implicit use of clojure.main with options is deprecated, use -M
{:demo "and a quote: \". <- A quote."}

Head has same behaviour as .767:

$ clj -Sdeps '{:deps {rewrite-clj/rewrite-clj {:git/url "" :sha "0bf3ee3ac625738f7fa3e5e163039e1bcf47fff2"}}}' -e '(do
(require (quote [rewrite-clj.zip :as z])) 
(-> (z/of-string "{}") 
    (z/assoc :demo "and a quote: \". <- A quote.")
    (z/root-string)
    (println))
)'
Cloning: 
Checking out:  at 0bf3ee3ac625738f7fa3e5e163039e1bcf47fff2
WARNING: Implicit use of clojure.main with options is deprecated, use -M
{:demo "and a quote: ". <- A quote."}

> Thanks for your time and reply 🙂 My pleasure!

Thanks for comparing against v0.6.1, that is interesting. I’m more confused, frankly, by 0.6.1 behaviour than 1.0.767 behaviour. I’ll take a deeper look.

So more narrowed down to the coercion, we can see the difference: v1

❯ clj -Sdeps '{:deps {rewrite-clj/rewrite-clj {:mvn/version "1.0.767-alpha"}}}'        
Clojure 1.11.1
user=> (require '[rewrite-clj.node :as n])
nil
user=> (n/coerce "hey \" man")
<token: "hey " man">

❯ clj -Sdeps '{:deps {rewrite-clj/rewrite-clj {:mvn/version "0.6.1"}}}'        
Clojure 1.11.1
user=> (require '[rewrite-clj.node :as n])
nil
user=> (n/coerce "hey \" man")
<token: "hey \" man">

Raised an isssue: https://github.com/clj-commons/rewrite-clj/issues/176

@borkdude would you mind having a peek and sharing your opinion on the issue? My current feeling is that I unknowingly (at least I don’t remember) fixed an issue in v0.

@lee Will do later this week!

Isn't this just the printing behavior?

That’s what I thought at first, but am now convinced otherwise.

Looks like v0 effectively escaped " in strings when coercing.

Which seems wrong to me, but wanted a borkpinion.

yeah, that seems wrong to me too

I would expect it to print <token: "hey \" man"> though

although, maybe the nodes don't use prn but println style ?

yeah nodes override default pr with a println style.

ok, in that case I would say v1 makes more sense

I thought so too.

I don’t know that v0 meant to do what it was doing there.

Update examples in https://github.com/clj-commons/rewrite-clj/issues/176 to use pr to make things clearer (even to me!). We are wrapping a string in " so we need to wrap any inner " (I’ve flip flopped and now think rewrite-clj v0 is correct).

yes, agreed

So @ivar.refsdal, it took my a while to get there, but I finally understand! Thanks so much for raising this, I’ll follow up with a fix sometime soon.

(and also thanks @borkdude, as usual!)