Fork me on GitHub
#rewrite-clj
<
2021-05-07
>
lread00:05:51

Ya @mauricio.szabo, I can probably do something about this. It is related to how I export fns to the public API. I personally find clj-kondo’s deprecation warnings more fine grained and useful than the cljs compiler’s and have been turning them off for the cljs compiler via :fn-deprecated false under :compiler-options.

lread00:05:36

But not everyone uses clj-kondo, I’ll raise an issue to change the way I export deprecated fns to the public API.

lread00:05:19

In the meantime, if it works for you, you can disable deprecations warnings from the cljs compiler. https://github.com/clj-commons/rewrite-clj/blob/886716ec4208958667b78fda74012d25e055bca4/script/test_shadow_cljs.clj#L15-L17.

lread00:05:29

And @mauricio.szabo? Thanks for bringing this up! Much appreciated.

mauricio.szabo01:05:40

No problem! I was already disabling the warnings on the compiler, too :)

mauricio.szabo01:05:12

Also, rewrite-clj is working beautifully on replacing the CLJS version I was using too!

mauricio.szabo01:05:08

Even things that I was fearing it would work differently, like zipper with line+col elements are working :)

lread13:05:04

Awesome to hear @mauricio.szabo, thanks for sharing the good news!