Fork me on GitHub
#rewrite-clj
<
2020-06-25
>
snoe14:06:55

@lee was clojure-lsp a dropin replacement of rewrite-cljc then?

lread14:06:26

If you ignore the hacks I did due to the fact that rewrite-cljc is not up on clojars yet.

snoe15:06:22

beauty! I actually vendor rewrite-clj so I'm gonna convert this weekend. Amazing work and dedication on this project, thank you!

lread15:06:32

You might want to wait until this is up on clojars... but... up to you! 🙂

snoe17:06:39

https://github.com/snoe/clojure-lsp/pull/150 I'm gonna mull it over, are you waiting on clj-commons before going to clojars?

lread19:06:21

Ya, I don’t want to confuse with a lread version and then a clj-commons version.

👍 3
borkdude15:06:03

snoe: fyi, I've also vendored rewrite-clj, for 3 reasons: 1) I didn't want to deal with whitespace because I'm only linting (for you this is different, since you actually rewrite). 2) fixed bugs (namespaced maps, maybe some others) 3) I wanted to deal differently with metadata nodes: I wanted metadata to be a child of a node, not a parent.

borkdude15:06:41

however, I might include the "real" rewrite-clj as well in the future, if actually want to rewrite something like clj-kondo config. who knows

borkdude15:06:06

anyway, I'm very excited about rewrite-cljc ❤️

borkdude15:06:42

I also volunteer as co-maintainer if you want

borkdude15:06:09

(as it's going to be on clj-commons)

lread15:06:07

@snoe, rewrite-cljc also brings in the paredit API from rewrite-cljs which might be of interest to you, dunno. https://github.com/lread/rewrite-cljc-playground/blob/master/src/rewrite_cljc/paredit.cljc

😍 3
lread15:06:29

@borkdude, that would be great!

slimslenderslacks19:06:42

@lee awesome, good to hear! That repo contains some code to watch clojars and send PRs to Repos that might need project.clj updates. We're about to release that to the community, along with a few other tools that people will hopefully find useful. One for formatting https://go.atomist.com/catalog/skills/atomist/cljfmt-skill and one for adding clj-kondo https://go.atomist.com/catalog/skills/atomist/clj-kondo-skill are almost ready to go (speaking of rewrite-clj!)

slimslenderslacks19:06:10

I'm excited to start using rewrite-cljc when it's ready

lread19:06:33

cool! I’ll announce when rewrite-cljc is up on clojars. It is open source, so... not sure when, but it’ll get there.

👍 3