Fork me on GitHub
#rewrite-clj
<
2019-06-12
>
lread00:06:13

good points @sogaiu !

borkdude16:06:31

I’d like to maintain a fork of rewrite-clj for clj-kondo, related to this issue: https://github.com/borkdude/clj-kondo/issues/254

borkdude16:06:12

considering the radio silence of the maintainer, I think I’ll just go ahead, as I think waiting for his reply can take forever…

lread17:06:15

I’ll have something eventually @borkdude but am still currently distracted by some cljs work

borkdude18:06:11

@lee Oh, I’m not posting this to pressure you. I’m not sure if I will switch to an alternative version of rewrite-clj… I’ll probably strip out only the stuff I need and optimize it, less surprises

lread18:06:33

I did not think you were pressuring @borkdude! If my version were available without current rewrite-clj bugs, you’d probably use it though, right?

borkdude18:06:12

if the tests would pass and performance was equal or better, probably yeah!

lread18:06:46

Oh the pressure! 😅

borkdude18:06:08

although I’ll probably need features that are too specific for rewrite-clj, like stripping out whitespace at parse time, etc. so I’m not sure

borkdude18:06:32

if anything, I’d like to contribute all my changes back to the (actively maintained) original if that was meaningful to anyone

lread18:06:48

they will be most welcome

borkdude18:06:48

if I would make a different thing I mean

borkdude18:06:32

eastwood also inlines dependencies to avoid conflicts

lread18:06:56

hmmm… that’s interesting… unrelated but I was trying to use figwheel main to run rewrite-clj cljs tests and had to exclude rebel readline because it itself uses rewrite-clj…

borkdude18:06:19

right, that’s what I mean 😉

lread19:06:37

(in other words, you taught me something yet again)