Fork me on GitHub
#rewrite-clj
<
2019-04-24
>
lread17:04:18

Thanks @sogaiu, I have applied your fixes to find-last-by-pos to my spike branch. I beefed up the unit tests in this area - your sample form provided above came in handy, thanks! https://github.com/lread/rewrite-cljs-playground/blob/cljc-spike-2/test/rewrite_clj/zip/findz_test.cljc#L141 One thing I am unsure of is, as you noted, when finding past an end of line, the function returns end of line. I think this might be ok, but you might have other ideas. When searching past the end of the entire form we return nil.

lread17:04:53

And thanks @sogaiu and @borkdude, I am now being explicit with reader conditionals on type hints. Totally makes sense.

sogaiu20:04:52

@lee i am about to be in transit for a day or so, but hope to get back to you before long. thanks for your continued work :)

lread22:04:33

happy travels!