This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2019-04-24
Channels
- # beginners (64)
- # calva (40)
- # cider (76)
- # clara (13)
- # clojure (72)
- # clojure-dev (34)
- # clojure-italy (4)
- # clojure-nl (14)
- # clojure-poland (1)
- # clojure-uk (30)
- # clojurescript (58)
- # clr (10)
- # core-async (101)
- # cursive (31)
- # datomic (9)
- # emacs (20)
- # fulcro (2)
- # jackdaw (1)
- # jobs (3)
- # juxt (3)
- # luminus (4)
- # lumo (15)
- # mount (4)
- # nrepl (29)
- # nyc (1)
- # off-topic (27)
- # qlkit (1)
- # quil (5)
- # re-frame (19)
- # reitit (8)
- # remote-jobs (4)
- # rewrite-clj (5)
- # shadow-cljs (45)
- # spacemacs (22)
- # sql (9)
- # uncomplicate (1)
- # xtdb (14)
Thanks @sogaiu, I have applied your fixes to find-last-by-pos to my spike branch. I beefed up the unit tests in this area - your sample form provided above came in handy, thanks! https://github.com/lread/rewrite-cljs-playground/blob/cljc-spike-2/test/rewrite_clj/zip/findz_test.cljc#L141 One thing I am unsure of is, as you noted, when finding past an end of line, the function returns end of line. I think this might be ok, but you might have other ideas. When searching past the end of the entire form we return nil.
And thanks @sogaiu and @borkdude, I am now being explicit with reader conditionals on type hints. Totally makes sense.