Clojurians Log v2

I might even be able to open files in IntelliJ by clicking a link in. a stacktrace or line number! https://www.jetbrains.com/help/idea/opening-files-from-command-line.html

re idea: great find, that might be useful to integrate in reveal!

Agreed! Thoughts on how someone might configure something like that in the case they're not using Cursive?

re showing assertions: I'd go with clojure.test reporting semantics, e.g. not showing the assert-expr, but by default showing counters instead.

maybe it makes sense to add more layers in the tree view for testing contexts?

i.e. the ones available with clojure.test/*testing-contexts*

Ah yeah, that could be nice!

The thing I worry about with the layout Cursive shows is near impossible usability when testing output gets large. That text area used would be absolutely massive.

I do agree that it departs from native reporting semantics, which I don't particularly like. Maybe there's some middle ground like collapsible sections in the text area thing.

does it happen that outputs are large even per testing context in a single test?

Yeah. Often a testing context will wrap many individual assertions.

but is it an often case that individual assertions have big logs around them?

my worry here is that this tree might also get pretty huge if we have something like this:

(dotimes [_ 1000]
  (is ...)))

re open in text editor/IDE — I imagine a preference key that allows specifying some well-known editors, maybe with automatic inference to see if vscode/intellij is installed, maybe with option to provide a command string with substitutable places. Maybe it can be available as an action on vars/nses and things resolvable to vars/nses.

In our case, yes. We deal with very large data structures. That's a great point. We also have some test vars with 10s of thousands of asserts 😅 (generated from data, akin to gen tests).

What about Cursive's output style (test tree left & assertion view right) where the assertion view has collapsible sections?

oh

in that case I think it makes sense to make collapsible/expandable outputs

What component do you suggest I use? I see the accordion but only being able to open 1 section seems super limiting...

re Cursive's output style — I think it won't work for reveal, mainly because reveal is usually in "portrait mode", e.g. bigger in vertical direction

so generally it's "cheaper" to align stuff vertically in reveal instead of horizontally

re testing context: Cursive does not include them in the test results tree view. I can easily include it, but I wonder if there was a reason he chose not to 🤔

I don't know

btw there is also a stack of testing vars in addition to testing contexts

clojure.test/*testing-vars*

e.g. if you do this:

(deftest foo
  (is ...))

(deftest bar
  (foo))

the is block will be in stack of bar and foo vars

not sure what to do with that 🤷

Oh wow. TIL. Cursive ignores that nesting. Here's what it looks like when I run a test like that.

Oh wait. It looks like it adds it as a space delimited list in the test var name.

Yep. I can do that too. I wonder if people use that grouping mechanism in practice.

they might, at least it's properly documented

Man, that testing-vars thing really messes stuff up. Gotta support it, but it adds some constraints. For example, before I was able to render all the tests that would run upfront. But now, I don't have a guarantee that the vars passed in represent the actual tests that will run. Basically, everything that was keyed by var can no longer be keyed by var 😢

(Cursive does this too -- dynamically adding tree items as they get discovered in test execution)

there is none!

Got it. Is it possible to add or is there some limitation?

No technical limitations.

There is some intentionality behind not allowing changing the size of open panels

Ah. What's the thinking?

I wanted to make default sizes as good as possible so there will be no need for tinkering with sizes

so you get a reasonably good view without doing anything

Makes sense. Perhaps there's some special conditions that would be better suited with specialized sizes?

There are some more things in this area I'm working on right now, e.g. maximizing the window with a shortcut (`F11`), so when you need to really focus on some view, it can be as big as possible

And other thing I want to do is opening views in new windows instead of result panels. This, combined with F11 to maximize allows you to make some view take basically the whole screen.

Cool! How would you control if a view opened in a new window or not? Something like combining shift+enter?

exactly this!