Clojurians Log v2

I tried this out, but I can't find what I was looking for. I'd like to grab the route string (what becomes the :template key in a Match object), but I can't seem to find it. During middleware compilation, where is it? Somewhere in the route data? Or the route opts?

If anyone knows how this works please point me the right direction 🙏

I guess I'm running into this every year: how do I find the template path for a route while compiling middleware?

good question! we might not be exposing it

into-middleware is only given the route data, not the path

is that something that's not even ready at that point? I have to include this "normalized path" in access logs so it'd be huge utility if it was available without injecting the match into the request map

I think we should have the resolved paths available at that point, we just don't pass in the path to any of the compile-ish functions

could you create an issue for this? we can then try to figure out how big of a change this is architecturally and other people can add their use cases there.

ok right away

let me correct my earlier statement: the compile-ish functions get a [path data] tuple. The problem is that reitit.middleware/compile-result isn't passing the path to into-middleware (via expand-and-transform )

you could add a custom compiler that does something like...

(defn compile-add-path [[path data] _opts _scope]
  (assoc data :path path))

but I haven't really ever used the :compile extension point for r/router so I can't tell you the specifics

as you say, the compiler does get the path, but i don't know what else it's supposed to do. what's the default for that? my Middleware doesn't get compiled. i assume the default compiler calls something but I couldn't find where or what

so there are two compilers 1. the route compiler, used to turn routes into results, given to the :compile option of reitit.core/router 2. the :compile of a middleware represented as a map (data-driven middleware), invoked by the into-middleware method of the IntoMiddleware protocol

number 1 gets the path, number 2 doesn't

reitit.middleware/compile-result is a compiler in the 1 sense that then invokes the compilers of the 2 sense

So my route compiler would need to call compile-result?

yeah, you'd want to hand off to compile-result

so maybe

(defn compile-add-path [[path data] opts scope]
  (compile-result [path (assoc data :path path)] opts scope))

I don't really understand how we compose route compilers

I guess we don't, there are just various verisons of compile-result. The one you want to wrap might actually be reitit.ring/compile-result

if you use reitit.ring/router to build your router currently, that is

Thanks, I'll give that a try!

It worked!

(defn compile-add-path
  [[path data extra] opts] ;; there doesn't seem to be a `scope`
  (reitit.ring/compile-result [path (assoc data :path path) extra] opts))

I'm glad that helped. You should still create that issue though! You can include your workaround in the description.

Yeah I'll do that later today

https://github.com/metosin/reitit/issues/720

Sure there is: https://cljdoc.org/d/metosin/reitit/0.7.0-alpha7/doc/ring/compiling-middleware

Awesome, thanks! Just what I needed

https://github.com/metosin/reitit/blob/master/doc/ring/exceptions.md