Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2023-10-30

Channels

#reitit
<
2023-10-30
>
Stig Brautaset10:10:06

blob-wave a few weeks ago I made tiny PRs fixing https://github.com/metosin/reitit/pull/655 and https://github.com/metosin/reitit/pull/654 in the documentation. I also added the ability to https://github.com/metosin/reitit/pull/656 Is there any appetite for these changes? I appreciate that we could use a custom project-specific coercer to cover that use case, so if it the added complexity is not desired I'm happy to close that PR.

juhoteperi10:10:38

The grammar change is OK. The old Clojure Jira links work for me, they just redirect to the new Jira, no reason to not update the links though I guess.

👍 1
gratitude-thank-you 1
Stig Brautaset10:10:54

Interesting. The redirects work for me too now. Not sure if it was a temporary failure, or if it's relevant that I was reading the docs on my phone at the time. 🤷

Stig Brautaset18:10:16

@U061V0GG2 am I correctly reading between the lines that there is not a desire to add the feature I suggested to the malli coercer? If so I'd rather close it, so it doesn't eat time every time I go through my list of open PRs. If it's interesting but just haven't been scheduled for review yet, I'm happy to keep it open.

juhoteperi19:10:38

I took a quick look and the code does make sense, but I didn't have time to consider it enough to see if we need it or if there are other good solutions. So you can just keep it open and we'll try to decide at some point. Unfortunately we haven't been super fast with all the PRs.

👍 1