This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2021-02-03
Channels
- # announcements (2)
- # atom-editor (1)
- # babashka (6)
- # beginners (49)
- # calva (39)
- # clj-kondo (20)
- # clojure (41)
- # clojure-australia (1)
- # clojure-europe (33)
- # clojure-germany (8)
- # clojure-italy (2)
- # clojure-losangeles (1)
- # clojure-norway (3)
- # clojure-spec (5)
- # clojure-uk (48)
- # clojurescript (147)
- # conjure (24)
- # core-logic (1)
- # datahike (6)
- # datomic (14)
- # emacs (10)
- # events (1)
- # fulcro (11)
- # garden (1)
- # girouette (2)
- # honeysql (16)
- # jobs (3)
- # kaocha (3)
- # malli (5)
- # meander (7)
- # off-topic (49)
- # pathom (50)
- # portal (3)
- # reagent (4)
- # reitit (7)
- # rewrite-clj (3)
- # ring (3)
- # sci (4)
- # shadow-cljs (46)
- # spacemacs (10)
- # sql (3)
- # tools-deps (57)
Moro! Looks like some Metosin libs (such as Muuntaja and Ring-http-response) have older and thus conflicting dependencies with Reitit (such as jsonista and ring-core). Would it be ok to make a PR to Muuntaja and Ring-http-response with just a dependency update – or is this already in the making?
Additionally commons-codec seems to be conflicting between Muuntaja and Reitit, but this is a transitive dependency in muuntaja via Cognitect’s transit-clj and transit-java, so the upgrade path is a bit longer there.
Great! Is it ok to assume that running tests with new dependencies is enough to check that they don’t break things? Most probably people are already running Muuntaja and Ring-http-response with newer dependencies when they are using Reitit in the same project.
Here we go: https://github.com/metosin/muuntaja/pull/119 https://github.com/metosin/ring-http-response/pull/23
I made a similar PR to Reitit as well: https://github.com/metosin/reitit/pull/469 The weird thing in Reitit was that newer dependencies caused less assertions to be run in tests. All tests passed though:
--- clj-test-master.txt 2021-02-04 08:43:51.000000000 +0200
+++ clj-test-upgraded.txt 2021-02-04 08:47:49.000000000 +0200
@@ -1,8 +1,8 @@
Performing task 'do' with profile(s): 'dev,base,system,user,provided'
-Ran 92 tests in 13.858 seconds
-3468 assertions, 0 failures, 0 errors.
+Ran 92 tests in 13.117 seconds
+3440 assertions, 0 failures, 0 errors.
Performing task 'do' with profile(s): 'dev,base,system,user,provided,1.9'
-Ran 92 tests in 13.079 seconds
-3572 assertions, 0 failures, 0 errors.
+Ran 92 tests in 13.333 seconds
+3317 assertions, 0 failures, 0 errors.