Fork me on GitHub
#reitit
<
2021-02-03
>
Ykä12:02:24

Moro! Looks like some Metosin libs (such as Muuntaja and Ring-http-response) have older and thus conflicting dependencies with Reitit (such as jsonista and ring-core). Would it be ok to make a PR to Muuntaja and Ring-http-response with just a dependency update – or is this already in the making?

Ykä12:02:40

Additionally commons-codec seems to be conflicting between Muuntaja and Reitit, but this is a transitive dependency in muuntaja via Cognitect’s transit-clj and transit-java, so the upgrade path is a bit longer there.

ikitommi12:02:53

PRs most welcome

👍 3
Ykä13:02:24

Great! Is it ok to assume that running tests with new dependencies is enough to check that they don’t break things? Most probably people are already running Muuntaja and Ring-http-response with newer dependencies when they are using Reitit in the same project.

Ykä13:02:18

Looks like lein all is the way to run all tests. I’m using that.

Ykä06:02:30

I made a similar PR to Reitit as well: https://github.com/metosin/reitit/pull/469 The weird thing in Reitit was that newer dependencies caused less assertions to be run in tests. All tests passed though:

--- clj-test-master.txt 2021-02-04 08:43:51.000000000 +0200
+++ clj-test-upgraded.txt       2021-02-04 08:47:49.000000000 +0200
@@ -1,8 +1,8 @@
 Performing task 'do' with profile(s): 'dev,base,system,user,provided'

-Ran 92 tests in 13.858 seconds
-3468 assertions, 0 failures, 0 errors.
+Ran 92 tests in 13.117 seconds
+3440 assertions, 0 failures, 0 errors.
 Performing task 'do' with profile(s): 'dev,base,system,user,provided,1.9'

-Ran 92 tests in 13.079 seconds
-3572 assertions, 0 failures, 0 errors.
+Ran 92 tests in 13.333 seconds
+3317 assertions, 0 failures, 0 errors.