@roklenarcic oh, would you have a time to do a PR to fix that?

@ikitommi I think the issue is that I'm using rring/create-resource-handler outside of a router, I am using it as a default handler. This is why path-params key is missing and path is always nil.

oh, sure. so, you could write it as:

(rring/ring-handler
  (rring/router
    [["/status" {:get {:handler (json/wrap-json-response status-handler)}}]
     ["/api" {:middleware (api-middleware logger)}
      ["" {:get {:handler api-handler}}]]]
    (rring/create-resource-handler {}))
  {:middlewre [wrap-gzip wrap-head]})

that's the same?

yes.

but router doesn't take a default handler

the second param is opts map

and ring-handler takes a default handler but not an opts map

(ring/ring-handler
  (ring/router
    [["/status" {:get {:handler (json/wrap-json-response status-handler)}}]
     ["/api" {:middleware (api-middleware logger)}
      ["" {:get {:handler api-handler}}]]])
  (ring/create-resource-handler {})
  {:middlewre [wrap-gzip wrap-head]})

yeah, but that's what I had and that doesn't work

because resource handler doesn't receive :path-params in request map

It looks for path param : (empty keyword) in :path-params key in request

this is absent

you need to set the :path argument.

(def app
  (ring/ring-handler
    (ring/router
      ["/status" {:get {:handler (constantly {:status 200, :body "ok"})}}])
    (ring/create-resource-handler {:path "/"})))

(app {:request-method :get, :uri "/docs"})

let me try

code here:

(if (resource-response (join-paths path file))
                                               (response/redirect (join-paths uri file))

Looks like it works now

in doc it says | :path | optional path to mount the handler to. Works only if mounted outside of a router.

should probably say that it's mandatory outside of a router

yes, it should.

could you make a PR?