Fork me on GitHub
#reitit
<
2019-02-17
>
colliderwriter17:02:05

@ikitommi I want to make sure I'm doing what you expect, so in this PR you expect to see my pedestal interceptor added to reitit-pedestal/src/pedestal.clj, and also an updated examples/pedestal-swagger/src/example/server.clj which uses it. Is that correct?

ikitommi19:02:14

another option would be to add new namespaces, like reitit.pedestal.interceptor with those in it. don’t have an opinion on that. what do you think?

ikitommi19:02:59

the exception interceptor drags clojure.spec in, so the ns loads bit slower. the reitit.pedestal is currently quite bare-bones.

colliderwriter19:02:11

Or perhaps my interceptor ought to wrap the sieppari version in order to prevent repeating the internal logic?

colliderwriter19:02:08

I recognize that there is a larger topic of interceptor unification at play.

ikitommi19:02:49

wrapping sounds good.

colliderwriter19:02:55

And in that case adding the .interceptor namespace seems reasonable since wrapping would drag even more in

👍 5
ikitommi19:02:08

Great. It allows people to choose. I think the default pedestal way is to have a one (the pedestal core-match thing) handler for all exceptions. But having a ready interceptor just for this is also ok.

colliderwriter19:02:52

I think that addresses all my questions. Will code and submit.