This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2019-02-17
Channels
- # beginners (26)
- # calva (7)
- # cider (6)
- # cljs-dev (7)
- # clojure (86)
- # clojure-europe (1)
- # clojure-finland (1)
- # clojure-spec (3)
- # clojure-uk (11)
- # clojurescript (18)
- # cursive (6)
- # data-science (1)
- # emacs (13)
- # fulcro (34)
- # juxt (8)
- # nrepl (6)
- # off-topic (11)
- # pathom (25)
- # re-frame (13)
- # reitit (11)
- # shadow-cljs (4)
- # spacemacs (3)
@ikitommi I want to make sure I'm doing what you expect, so in this PR you expect to see my pedestal interceptor added to reitit-pedestal/src/pedestal.clj, and also an updated examples/pedestal-swagger/src/example/server.clj which uses it. Is that correct?
@colliderwriter sounds good.
another option would be to add new namespaces, like reitit.pedestal.interceptor
with those in it. don’t have an opinion on that. what do you think?
the exception interceptor drags clojure.spec in, so the ns loads bit slower. the reitit.pedestal
is currently quite bare-bones.
Or perhaps my interceptor ought to wrap the sieppari version in order to prevent repeating the internal logic?
I recognize that there is a larger topic of interceptor unification at play.
And in that case adding the .interceptor namespace seems reasonable since wrapping would drag even more in
Great. It allows people to choose. I think the default pedestal way is to have a one (the pedestal core-match thing) handler for all exceptions. But having a ready interceptor just for this is also ok.
I think that addresses all my questions. Will code and submit.