Fork me on GitHub
#reitit
<
2018-10-17
>
valerauko00:10:29

thanks! what would be the ideal behavior for the param keys? i could look into it if you have any ideals in mind

thiru03:10:42

Thanks @ikitommi. Everything looks fine though. I'm sure I'm doing something stupid.. I'll keep digging

ikitommi07:10:52

@vale the param route data keys… could you give an example what you would like to have?

valerauko13:10:27

i don't have anything in particular in mind. you said that you feel it's still wrong in your comment though, which is why i was wondering if you have any image of what would be ideal. i'd happily implement it if you had

valerauko13:10:19

i suspect something like this?

(s/or :kw-map (s/map-of keyword? any?)
      :ds-map (s/map-of (instance? Spec) any?)
      :spec s/spec?)

ikitommi15:10:16

@vale oh, that, I did a quick fix by setting it to any? - data-specs can have record keys (via ds/opt and ds/req), same applies for Schema. Also, as the coercion is pluggable, there could be.. anything. https://github.com/metosin/reitit/commit/5046aebec8c530921d39a2f6bc721c1940d6c5bd

👍 4
ikitommi15:10:25

And really appreciate your help on these.

valerauko15:10:15

happy to help!