not sure if i've asked this before... how to do query-params properly? currently, while path and body params are key-indexed, query params are string indexed. also, they don't seem to get type-cast: i have a param specced as pos-int? but it still comes through as a string am i missing some setting or something somewhere?

should've searched before asking. solved!

actually my problem still stands: i'm coercing my query params like

(s/def ::page pos-int?)
;; ...
{:query (s/keys :opt-un [::page])}

@vale all coercible specs need to be wrapped, the two ways to do it: 1) use data-spec syntax: {:query {:page pos-int?}}, it just works 2) wrap it manually:

(s/def ::page (spec-tools.core/spec pos-int?))

;; or

(s/def ::page spec-tools.spec/pos-int?)

can that handle optional parameters?

{:query {(ds/opt :page} pos-int?}}

(I think we could merge the spec-tools & spec-coerce approaches and make all the simple specs to coerce without any wrapping too)

with that, your initial code would work too.

i figure that'd take changes to reitit itself?

In: [:parameters :query #spec_tools.data_spec.OptionalKey{:k :page} 0] val: #spec_tools.data_spec.OptionalKey{:k :page} fails spec: :reitit.core.coercion/kw-map at: [:parameters :query :map 0] predicate: keyword?

oh it had to wrapped in a ds/spec

did you get it working?

yeah like

{:get {:summary "List of accounts following the user"
             :responses {200 {:body any?}}
             :parameters {:query (ds/spec ::opt-page {(ds/opt :page) pos-int?})}
             :handler user/followers}}]]]

it should work without the ds/spec

without the ds/spec it threw the error i pasted above

i tried {:query {(ds/opt :page) pos-int?}} and it errored

that's weird. Could you file an issue out of that?

sure

there is one already

#145

at least i think it's the same issue

is there an api to access the compiled, flattened (final) routes?

is .compiled-routes something i can rely on? does it change at runtime?

https://metosin.github.io/reitit/basics/name_based_routing.html found what i was looking for~

i'm trying to write a quick macro to generate a bunch of path helper functions

name lookups make it really easy

routers are effectively immutable once created. compiled-routes can be used for extensions, for example the swagger docs are created from those. We'll mark on changelog if the interals change for some reason.

what kind of path helpers are you creating btw?

something like what rails does

(user-show-path :id 1 :query {:foo "bar"})

cool. the ds/spec, worked here ok, commented on the issue...

is there a way to coerce params in match-by-name! ?

did you read https://metosin.github.io/reitit/ring/reverse_routing.html ?

i have a route with a required param :id pos-int? but it accepts false for example

(reitit.core/match-by-name! router :person {:id false})

this makes a Match that has :path-params {:id "false"}, :path "/person-path/false"

currently, there is no validation, but one could do that using the route data and reitit.coercion. maybe there should be a helper for it?

lemme try that

currently it would fail when doing the actual route call, not when constructing the path.

need to go.