This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-11-12
Channels
- # announcements (15)
- # babashka (8)
- # babashka-sci-dev (8)
- # beginners (19)
- # biff (18)
- # cider (7)
- # clj-kondo (1)
- # clojure (6)
- # clojure-europe (24)
- # clojure-norway (10)
- # clojure-spec (1)
- # clojurescript (11)
- # conjure (1)
- # core-async (1)
- # cursive (3)
- # devops (1)
- # emacs (1)
- # fulcro (1)
- # helix (4)
- # keechma (1)
- # off-topic (19)
- # pathom (4)
- # reagent (2)
- # reitit (1)
- # shadow-cljs (8)
- # spacemacs (1)
- # vim (7)
https://github.com/aengelberg/paren.party/blob/master/src/paren/party.cljs I love the way this animation is done. It simply calculates the positions based on the time. In an old episode of cognicast, @aengelberg claims he had no idea what he was doing. Is this considered a recommended approach? I don't know if it's bad form to request a code review of someone else's old project. If so I sincerely apologize.
I'd rename some functions (like render-something
into something-view
), use reactions instead of functions to make it explicit that it's a reactive thing, and avoid derefing ratoms in JS handlers even when it seems to be OK to do so. And I would not use cljsjs
nowadays, remove unused imports, replace mt/every
with some hand-rolled impl to avoid an extra dependency just for that simple function, and would use reagent.core/atom
via reagent/atom
and not by shadowing the built-in atom
.
Other than than, seems alright.