I’m just upgrading to 0.8.0 and when I run my unit tests with doo I now get

Error while loading file: "target/test.js"
ReferenceError: "Set" is not defined
At line 153

ERROR: doo was not loaded from the compiled script.

With 0.7.0 I get a successful test run.

Is this issue known to anyone?

@peterwestmacott What js env are you using with Doo? Phantom?

Could be new React no longer works with Phantom

nashorn

Set could refer to React using ES6 Sets

oh, so could be latest reagent uses latest react which uses JS features not supported by my runtime?

sounds super-plausible

The JS line-number it gives me is deep in the minified version of React

Quick search says that Nashorn ES6 support requires Java 9

https://reactjs.org/docs/javascript-environment-requirements.html

yep - I’m just coming to that conclusion - but thanks for confirming

looks like I need moar Java

what do you guys think of this problem? https://clojureverse.org/t/theming-a-reagent-app/2026

Its not specific to Reagent. Theming is always a challenge. One thing that can ease the pain is to use the new React Context API and another solution is explore tools like css modules or styled-components / glamor - ideally you would combine both of these.

yeah, I guess I should have specified that we're using emotion.sh already

which uses context under the hood i'm pretty sure. it's just kind of gross to use with reagent

emotion is?

ah no, the react integration & ThemeProvider

I don't see any examples of using ThemeProvider without the styled.htmlElement or HOC

we just create style objects that we pass in as edn and then pass those in to the components as classes