Fork me on GitHub
#reagent
<
2018-02-23
>
theasp19:02:03

Does anyone have an easy workaround for icons not changing when the dom changes with fontawesome 5.0?

theasp19:02:36

I opted for the hard route, I'm no longer using FA, but I guess adding metadata to the icon hiccup would work too

justinlee19:02:15

do you have a repro? I’m sure i followed the original question

justinlee19:02:47

@theasp do you mean when you changed the class on the i tag the rendered html didn’t change, or it did change but the browser didn’t accept it?

theasp20:02:12

@lee.justin.m FA 5.0 uses SVG, [:i.fas.fa-whatever] creates a svg subelement which doesn't automatically propagate changes from [:i] when it's classes changes

justinlee20:02:55

oh i’m using fa 4.7

justinlee20:02:11

i actually don’t know how it works

justinlee20:02:29

i’m jus wondering if it is a reagent issue or a this-is-how-fa-works issue

justinlee20:02:01

if it is reagent i might be able to help diagnose, but if it is something quirky with fa i haven’t encountered it before

theasp20:02:54

it's not a reagent issue, just an annoying design decision

theasp20:02:08

it's no longer just a font

theasp20:02:25

there is some magic js you load and then hope for the best

justinlee20:02:06

i never really understood how it worked. i just copied random stuff hither and thither and it worked and i never messed with it again 🙂

jasonjckn21:02:39

Q1: are most reagent users reframe users ? (what’s the ratio?)

jasonjckn21:02:11

Q2: are they’re any other contenders to reframe powered by reagent

justinlee21:02:57

i have no idea what the ratio is. i just use plain reagent.

mikethompson21:02:32

Reagent alternatives include: - keechma - https://github.com/keechma/keechma - Carry - https://github.com/metametadata/carry Non-reagent based: - RUM/Citris - fulcro - Hoplon My rational for using re-frame over pure reagent is given here: https://github.com/Day8/re-frame/blob/master/docs/FAQs/DoINeedReFrame.md

mikethompson21:02:59

As to percentages ... my guess is that 75% of commercial Reagent use involves re-frame. That's an estimate based on watching the job ads over the last year. When Reagent gets mentioned, re-frame is almost always mentioned as well. Hard to know about individual use. Might be closer to 50/50 because individuals often want to enjoy the process of creating their own thing. But that's pure guess work.

jasonjckn21:02:20

@mikethompson great summary, thank you

jasonjckn21:02:40

@mikethompson I saw reframe slack channel is mostly empty, but presumably they’re here

mikethompson21:02:11

The #re-frame channel is pretty active

shaun-mahood21:02:35

#reframe is a bad alias I guess. I'll see if we can get it removed

jasonjckn21:02:44

ah yes, was on #reframe

shaun-mahood21:02:36

Duplicate alias is gone thanks to the always helpful @seancorfield