Fork me on GitHub
#reagent
<
2018-02-21
>
justinlee01:02:16

hey react users, @mikethompson, @mikerod (and any other mikes of the world), I finally pulled together most of the documentation from /docs and from the release notes into a single markdown file. I have also added my own React interop guide. For now, I just put the draft up here https://gist.github.com/jmlsf/17c588deb326e538dcea6847bc66db9b but I’d appreciate thoughts on how best to finish this up and share it. I have read through https://github.com/reagent-project/reagent/issues/209 and realize there are a lot of opinions on doc technology, but I think the advice to just get the content done in the easiest way possible is well taken. Is a pull request the right thing to do here? I want people to be able to contribute easily. There are quite a few TODOs in places where my knowledge is missing.

mikerod14:02:21

@lee.justin.m I think there are good comments on the PR 343 at this point from those who have more to say regarding organization and process.

mikerod14:02:29

I read the section that I believe that you added on “Interop with React” and I think it was well said and captures what I think would be helpful to people there. So I don’t have anything to add other than +1 to that section. I’ll keep an eye on the Reagent docs overall and that PR to see how things go from here.

gadfly36101:02:22

@lee.justin.m Woohoo, this is exciting! Yes, I think a PR is the right thing to do here

justinlee01:02:58

so maybe just add it to docs and do a PR?

gadfly36101:02:30

sounds good to me

gadfly36102:02:34

@lee.justin.m If you haven't seen it, 302 (https://github.com/reagent-project/reagent/issues/302) is also a relevant issue along with 209 which you already referenced

justinlee02:02:11

Yea I read all of the documentation-tagged issues

justinlee02:02:26

that list of things is in the “TODO” section at the bottom

gadfly36102:02:57

Awesome 🙂

justinlee02:02:32

okay PR #343 submitted

gadfly36103:02:45

@lee.justin.m sent over a PR to your version ... just adding tags to a few missed source code blocks