Fork me on GitHub
#reagent
<
2018-02-15
>
worlds-endless22:02:46

I have :component-did-mount generate-network-graph in my create-class. generate-network-graph has a 0-variadic and a 1-variadic method; to my surprise, the :component-did-mount is passing something in, though. Documentation anywhere doesn't seem to mention it. What's going on?

lee.justin.m23:02:21

it passes in a this parameter according to the create-class docstring

mikethompson23:02:10

vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv REMINDER: /docs is now a thing in the Reagent repo https://github.com/reagent-project/reagent/blob/master/docs/README.md And so is FAQs: https://github.com/reagent-project/reagent/tree/master/docs/FAQ

mikethompson23:02:27

... more is needed ... and this needs to be a community effort

mikethompson23:02:43

... for example :> is virtually undocumented

mikethompson23:02:28

There should be a single page of docs on adapting React components for use in Reagent

mikethompson23:02:44

And it is YOU who should write it :-) What was it that puzzled you when you started with Reagent? Can you write a few paragraphs on it? Submit it as a PR? (Warning I'll be repeating this message every week for the next couple of weeks) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

lee.justin.m23:02:47

I’m working on that last part

lee.justin.m23:02:41

and i really do intend to suck up all the random information stuck in the release notes

lee.justin.m23:02:20

i really like the gitbook style of documentation, though i’m sure there are other technologies available. any thoughts on that? maybe it is hard to collaborate/maintain?

mikethompson23:02:56

Getting the content (words) right is the most important part

mikethompson23:02:04

After that can come beauty

mikethompson23:02:26

Of course, both could happen at once, but I'd favour the first if there was any change the second could cause delay

lee.justin.m23:02:59

Okay well I’l just work on the content first.

mikethompson23:02:17

I appreciate that

lee.justin.m23:02:25

By the way, do you know why the codox documentation is all janky?

mikethompson23:02:59

I don't ... the Reagent toolchain has always been difficult for me (because I'm on Windows ... don't mock)

lee.justin.m23:02:14

If I had any influence over our profession I would try to convince all javadoc type documentation generators to let go of alphabetical order. 🙂

lee.justin.m23:02:28

It’s not like this is printed and you need to find something by flipping through paper.