Fork me on GitHub
#reagent
<
2017-08-07
>
captainlexington03:08:59

Thanks @mikethompson, good point! However, switching to for didn't have the performance boost I was looking for. I think most of the cycles are used on non-drawing actions. I'll have to do more testing!

urbank07:08:01

Does reagent compare reference types when deciding whether to update?

octahedrion10:08:06

depends - it uses identical? for atoms, = for everything else i think

borkdude15:08:01

What is the recommended set of dependencies when you want to use Reagent 0.7.0 with React with addons? I now use these:

[reagent "0.7.0"]
    [cljsjs/react-with-addons "15.5.4-1"]
    [cljsjs/react-dom-server "15.5.4-1"]
    [cljsjs/react-dom "15.5.4-1"]
    [cljsjs/create-react-class "15.5.3-0"]
 
and I get these warnings: > react-with-addons.inc.js:4946 Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

pesterhazy15:08:06

are you using any 3rd party libs that use React?

pesterhazy15:08:28

I don't think that reagent uses PropTypes

borkdude15:08:11

I’ll check it out

borkdude15:08:55

Sablono appears to be it, coming along with devcards

borkdude15:08:46

Upgrade should fix it

juhoteperi16:08:20

React-with-addons is deprecated, I think it will always show that warning

juhoteperi16:08:36

React-with-addons uses the deprecated React API and won't be updated

juhoteperi16:08:16

cljsjs/react-transition-group provides the animation utils from react-with-addons: https://github.com/cljsjs/packages/tree/master/react-transition-group

juhoteperi16:08:24

react-addons-perf and react-dom/test-utils are AFAIK currently only usable with Webpack, and looks like making browserified bundle from these will be hard

juhoteperi16:08:51

They might work with :npm-deps in the latest Cljs