Fork me on GitHub
#reagent
<
2017-08-02
>
lwhorton17:08:05

hey guys, not sure if this is the right place to ask- but with respect to https://goo.gl/UyByC4 and the cljs npm-deps changes: do the compiler changes mean we dont have to have externs files for npm deps now?

gadfly36117:08:41

I think externs will still be needed

pesterhazy18:08:57

I think reagent 0.8 will depend on cljsjs.reagent, which still contains the externs

juhoteperi18:08:38

AFAIK there is one place in React where event properties are generated dynamically, and because of that externs are needed

juhoteperi18:08:38

But I don't have any source for this, other than "was discussed somewhere", and I don't know what the place is

juhoteperi18:08:03

Some npm JS code will work without externs, but some libraries (many?) contain some strange dynamic code Closure doesn't properly understand, which breaks without externs

juhoteperi18:08:28

Ah, here is the issue at React about these event names: https://github.com/facebook/react/issues/9417

juhoteperi18:08:10

If React didn't register those plugins dynamically there, Closure could properly rename the names everywhere