This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-06-27
Channels
- # bangalore-clj (2)
- # beginners (37)
- # boot (16)
- # cider (17)
- # clara (4)
- # cljs-dev (351)
- # cljsrn (16)
- # clojure (219)
- # clojure-belgium (4)
- # clojure-dev (3)
- # clojure-france (2)
- # clojure-italy (24)
- # clojure-russia (23)
- # clojure-spec (55)
- # clojure-switzerland (3)
- # clojure-uk (89)
- # clojurescript (121)
- # cursive (2)
- # datomic (29)
- # devops (2)
- # graphql (8)
- # hoplon (15)
- # immutant (5)
- # lein-figwheel (4)
- # liberator (3)
- # luminus (18)
- # off-topic (9)
- # om (6)
- # onyx (31)
- # pedestal (48)
- # precept (9)
- # re-frame (19)
- # reagent (63)
- # ring-swagger (69)
- # robots (1)
- # slack-help (14)
- # spacemacs (12)
- # sql (2)
- # test-check (4)
- # unrepl (28)
- # untangled (5)
- # yada (3)
anybody else running into the problem with clojurescript 1.9.655 and reagent? https://github.com/reagent-project/reagent/issues/293
@kommen , I'd bring it up in #cljs-dev , ideally along with a minimal example using only the ClojureScript jar (no lein)
@pesterhazy ok, thx
I'm not sure either
I'm planning on releasing 0.7.0 with partial-ifn fix (https://github.com/reagent-project/reagent/pull/303) & few other small changes
The fix could be released as 0.6.3 but I have already merged some potentially breaking changes (removed some deprecated macros) so I think incrementing the version number is good idea
I could also create 0.6 branch and backport the partial-ifn fix there but I guess everyone can as well just update to 0.7.0
one problem I see is that it requires a newer version of react
because of the create-react-class dependency
in other words, it wouldn't be a drop in replacement for 0.6.2
That's why the version number is 0.7.0
Perhaps there won't be this great hurry for new release, lets see if Cljs will get the fix
agree
that'd be much better, then we can fix it at our own pace
FWIW, your snapshot release fixes @kommen's test case: https://github.com/pesterhazy/reagent-655
I've tried to reproduce the issue with r/wrap but couldn't. So does this only happen when you use r/partial manually?
@pesterhazy Did you try using reset!
with the wrap value? That should call invoke on the callback which is created with partial-ifn
yeah I did
like this
(let [a (r/wrap 15 swap! my-atom assoc :foo)]
(reset! a 20)
(prn [:a @a]))
seemed to work fine
n00bie question: I want to try this React component (https://github.com/zenoamaro/react-quill). How would I plug this into Reagent? BTW: yes, I’m aware of the markdown-editor recipe in the Reagent Cookbook.
@felipe-campos does this help? https://gist.github.com/pesterhazy/4a4198a9cc040bf6fe13a476f25bac2c
if you're stuck with the tooling aspect, this post may help https://github.com/pesterhazy/presumably/blob/master/posts/double-bundle.md
@pesterhazy @juhoteperi fwiw, as I wrote in #cljs-dev, with cljs 1.9.660 reagent 0.6.2 keeps working and just prints a warning
Yeah, tested it myself also
I updated the changelog already to say the new version fixes the warning
@pesterhazy thanks, man!
@juhoteperi would it make sense to push out a release?
Yes, I'll do that now
Pushed
> Reagent has now dependency on cljsjs/create-react-class, if you are using other methods to provide React, you need to exclude this Cljsjs dependency and provide the library yourself.
do you also need to provide a mock namespace?
Yes 😞
.o0(if only there were surrogate packages)
maybe it would be worth pointing out the mock namespaces in the changelog?
Readme should probably be updated, it now mentions just mock cljsjs.react
ns but it should also mention react.dom and create-react-class
another thing, which React version is the minimum necessary for reagent 0.7.0? 15.5.0?
I'd be happy to do a PR with those changes
Versioning for create-react-class at least starts from 15.5.0, not sure if that will work with older React + React-dom
I think 15.5.0 as a minimum is a good guess
Thanks @juhoteperi for your great work on Reagent by the way and congrats for the 0.7.0 release
@pesterhazy Thanks, I have mostly been fixing bugs we'd hit at work anyway, still plenty of open bugs and PRs that I haven't had time to look at
any recommendations for ui frameworks that play well with reagent? there is a bootstrap wrapper i see, how about foundation or others?
We've used https://github.com/madvas/cljs-react-material-ui, it's okay.
Well, I guess it's not ui framework in the same way as Bootstrap or Foundation. Anyways.
i'm a bit new to 3rd party front end ui frameworks ,i've always rolled my own css, etc but i don't have the time for that now, so trying to swim through all the options
it's been hard to understand exactly what kind of stuff is hidden inside these frameworks that might or might not conflict with reagent
There's usually lots of information about what works with React and what doesn't. As a rule of thumb, if it works with React, it will work with Reagent.
i assume there might be a bit of using the react adapt-class tools in reagent for some of these with react bridges already
You're right. For example, if you look at cljs-react-material-ui's Reagent support: https://github.com/madvas/cljs-react-material-ui/blob/master/src/cljs_react_material_ui/reagent.cljs