Hey all, I’m upgrading dependencies, and I’m getting a Something is calling a React component directly. Use a factory or JSX instead warning. Google led me to some examples that seemed more specific than I needed. Here’s the code:

(let [html (vis/get-html vis response)
            js (vis/get-js vis response)
            reagent-comp (reagent/create-class
                           (merge {:component-function #(views/main-page html)}
                                  (if js {:component-did-mount js} {})))]
        (reagent/render reagent-comp (.getElementById js/document "app")))

views/main-page is just a function returning a hiccup tree with the passed-in html at the bottom

If I replace :component-function with :reagent-render, I get the same error

🦆 For those finding this in a log somewhere with the same problem, using with-meta like the reagent docs say (instead of following the re-frame doc like I was doing) fixes the issue

If I define reagent-comp as (if js (with-meta #(views/main-page html) {:component-did-mount js}) #(views/main-page html)) then everything’s wonderful

@snowell: you could try (reagent/render [reagent-comp] (.getElementById js/document "app”))

I think the warning is related to this

@rohit That does indeed also work!

I like that better since I still don’t fully understand with-meta 🙂

@snowell: sure. reagent/render expects a either a vector or a react element, where as in your code, you were passing it a ReactClass

I guess before it either worked differently or didn’t care

But that explanation makes lots of sense

Maybe they were less strict earlier.

http://blog.ducky.io/reagent-docs/0.6.0-alpha2/reagent.core.html#var-render

This has the API documentation

Ah, I was on 0.5.x before

ok

which version are you now on?

0.6.0-rc

awesome!