Fork me on GitHub
#reagent
<
2015-07-17
>
coyotespike00:07:12

(also have a paginator, which is simpler to make, but still)

gadfly36100:07:37

I'm happy to consider multiple PRs! Btw, simple isnt necessarily bad. As for quantity, I find it useful to have many working examples to draw from. Only thing I look for is focused recipes that dont try to cover too much.

nberger00:07:47

@coyotespike: the default clojure buildpack (https://github.com/heroku/heroku-buildpack-clojure) will run lein uberjar during the build if it finds :uberjar-name in project.clj. But the default Procfile will always run with lein

nberger00:07:01

you have to override the Procfile to run with the uberjar

surreal.analysis00:07:49

So no, it doesn’t actually use hiccup

coyotespike00:07:55

@gadfly361: great, I'll write it up and send it your way simple_smile

coyotespike00:07:29

@nberger: Thanks for the links - I'm pretty sure my configuration looks like that. My project.clj has :uberjar-name, my clojure.main has :gen-class, and my procfile looks like web: java $JVM_OPTS -cp target/myapp.jar clojure.main -m myapp.server.

coyotespike00:07:07

(so myapp.server has the :gen-class invocation)

nberger00:07:30

have you tried the uberjar in your local environment?

coyotespike00:07:40

Sure have, and the carousel scrolls nicely along.

nberger01:07:53

do you have lein-cljsbuild plugin?

coyotespike01:07:51

and in :uberjar {:hooks

nberger01:07:27

hummm... ok... I remember I once had issues with uberjar doing a lein clean which in turn deleted compiled js files, but don't remember what was the exact files layout I had...

coyotespike01:07:07

Now, I did comment out minify-assets.plugin/hooks, on account of it was deleting all my edits to my CSS file. But I can't see that would make a difference.

coyotespike01:07:16

Oh, that's interesting...I'll do some digging

nberger01:07:28

aonther place to look into is the console in the browser, in case you didn't yet

coyotespike01:07:37

Good idea - no errors there though (except a re-frame warning, ha)

nberger01:07:52

I'd do try to reproduce locally... clean everything, not only lein clean but also manually check if all compiled js files were deleted, then run lein uberjar

coyotespike01:07:23

Cool, will do

coyotespike01:07:31

I appreciate the idears

nberger01:07:38

Cool. If you get to reproduce it that way, one thing to check is your :clean-targets and :output-to values, on your different cljs build profiles

coyotespike01:07:51

Well, I confirmed app.js and

{:output-to "resources/public/js/app.js"
 :output-dir "resources/public/js/out"
were both deleted, but it still works after lein uberjar.

coyotespike02:07:31

I'll look up different Procfile configurations, see if I can spot a difference. Thanks!

nberger02:07:59

np. good luck, come back with more info if it still fails, and maybe continue asking in #C03S1L9DN

coyotespike02:07:58

Good idea, thanks simple_smile

pupeno08:07:19

Is reagent’s template safe by default? Or is it an xss waiting to happen like Hiccup?

borkdude08:07:25

@pupeno: Reagent -> React and React's template is safe by default

pupeno08:07:50

@borkdude: good simple_smile I can’t believe Hiccup is not.

Petrus Theron11:07:16

Where should I ask for re-com help?

meow11:07:21

@petrus: probably on the #C073DKH9P channel

curtosis13:07:57

any reagent-forms wizards here today?

curtosis15:07:09

argh.... 8 hours tracking down a single-character typo. turns out reagent-forms/bind-fields wants a vector template, not a function. (def form-template ...) not (defn form-template ...) facepalm

curtosis15:07:41

which is blindingly obvious ... now.

gadfly36115:07:48

Glad you figured it out!

curtosis15:07:58

helping me on the path to egoless programming. simple_smile

dviramontes19:07:19

made that exact same mistake too