This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-05-20
Channels
- # aleph (11)
- # announcements (3)
- # babashka (35)
- # babashka-sci-dev (28)
- # beginners (29)
- # calva (51)
- # cider (33)
- # clj-kondo (26)
- # clj-on-windows (1)
- # clojure (40)
- # clojure-austin (1)
- # clojure-europe (47)
- # clojure-nl (9)
- # clojure-norway (7)
- # clojure-uk (5)
- # clojurescript (69)
- # conjure (30)
- # cursive (7)
- # data-science (9)
- # datomic (2)
- # etaoin (10)
- # events (2)
- # fulcro (1)
- # graalvm (1)
- # gratitude (6)
- # helix (16)
- # honeysql (20)
- # hyperfiddle (14)
- # inf-clojure (2)
- # jobs (1)
- # jobs-discuss (12)
- # kaocha (9)
- # leiningen (2)
- # lsp (4)
- # malli (8)
- # music (9)
- # off-topic (12)
- # pathom (10)
- # portal (14)
- # practicalli (15)
- # re-frame (27)
- # reitit (7)
- # remote-jobs (4)
- # sci (37)
- # shadow-cljs (16)
- # sql (8)
- # tools-deps (6)
- # vim (6)
- # xtdb (21)
I've been digging into the subscriptions sources (again) and I was curious (because they're so damn elegant) if they were invented/discovered by @mikethompson. Was there prior art, or did the design sort of fall out of the primitives reagent made available (reactions)?
I'm very new to all this, so please forgive me. My console is full of "re-frame: Subscribe was called outside of a reactive context." I think this is coming from re-pressed
because when I remove the related dispatch calls from my core namespace it goes away. Is there some trick to how the re-pressed config is dispatched? Or some way to suppress the warning in the console?
re-pressed was written before that warning was introduced. I don't use clojurescript often anymore and I am unfamiliar with the warning. Internally re-pressed is trying to grab a value from app-db for use inside a callback. If there is a better way to do that than a subscription, then I am open to a PR.
My understanding is that it's not a good idea to use rf/subscribe
outside a reactive context (in other words, ok = views, other subscriptions; bad = event handlers, js callbacks), as that may/will interfere with how stale subscriptions are detected and pruned.
hey re-framers, long time no see , next week new release of re-frisk, hot keys and app-db history
so if you want to find events in which value for a specific key in app-db was changed , you can do it now
also i know many asked for hidden UI and hotkeys, so now there is preload-hidden, which hide UI, and it can be opened with ctrl+H
Recently a few users have reported StackOverflow issues when compiling builds with re-frame-10x. We https://github.com/google/closure-compiler/issues/3945 this down to being a problem related to excessive string concatenation in highlight.js
language files. As far as I can tell none of these languages are relevant to what 10x is doing. Who do I need to talk to to get this tweaked so that only relevant languages are loaded? It will improve the build times for everyone and fix the problem as well.
Seems to be an issue with https://github.com/superstructor/re-highlight
It requires the whole library instead of just core
: https://github.com/superstructor/re-highlight/blob/master/src/re_highlight/core.cljs#L6
Thanks for following this up @U05224H0W As a library, the existing
highlight.js :as highlight-js
Supports both shadow and cljsjs etc.
If I do "highlight.js/lib/core"
I think this will use shadow-specific package resolving, and thus will break cljsjs compatibility ? That's probably acceptable regardless, as maintaining compatibility is not a big priority.
Is the above accurate ? Are there other options in terms of maintain compat ?alternate option would be a dedicated cljsjs package just for this that I can override via https://github.com/thheller/shadow-cljsjs
https://github.com/superstructor/re-highlight/commit/704a66db960e97d0a2ec5b3773a9fb93a0d8ec04 @U05224H0W
will do various releases of library then 10x etc ASAP
What's the status of the fixes above? I'm in the process of updating dependencies, and the macroexpanding error is the only thing blocking me.
Also, I have [superstructor/re-highlight "2.0.0"]
in my project.clj file and "highlight.js": "^11.5.1"
in my package.json - forgive me if this is a silly question, but do I need both of these?
@U03F0727DV0 re-frame-10x 1.2.8 or later includes re-highligher 2.0.0 https://github.com/day8/re-frame-10x/blob/master/CHANGELOG.md#128-2022-05-22
@U03F0727DV0 @U2FRKM4TW is correct that re-highlight depends on highlight.js, but re-highlight declares highlight.js as an NPM dependency for shadow-cljs builds only via https://github.com/superstructor/re-highlight/blob/master/src/deps.cljs So if you are depending on re-highlight then shadow-cljs will write it into your package.json if it doesn't find it there already. If you are depending on 10x, you shouldn't even need to depend on re-highlight because versions of 10x > 1.2.8 depend on a fixed version of re-highlight.
Hope that makes things clear.