> When an event handler is registered via reg-event-fx, it must return effects. maybe not?

> In fact, it is perfectly valid for an event handler to return an effects map of {}. Slightly puzzling, but not a problem.

nil should also be fine.

Exceptions in events should not make your app crash. Exceptions in subscriptions are exceptions in views - there are React error boundaries for that, and they will also catch errors within view functions as well. Alternatively, you can write wrappers for reg-event-* and reg-sub that wrap the handling code in try-catch.

thanks, yeah makes sense... I just realized the component causing the crash is outside my error boundary

> the former should contain as much logic as needed In aggregate, yes - because there's no other place where such logic could be put. But you can still split it into multiple functions and keep on reusing different parts of it. The reason for that statement about reg-fx is because effects are meant to be as reusable as possible. The more logic you put into them (assuming that logic is highly specific and is not applicable to all effects of that kind), the less you can reuse it.

Got it. Thank you!

Yes.

So you would use :fx in order to do more than one :dispatch since you can’t have duplicate map keys. And that also lets you define an order which they will occur in, whether that matters or not.

Right. But there's also :dispatch-n.

You can use the :dispatch-later effect.

https://day8.github.io/re-frame/api-builtin-effects/#dispatch-later

ah, ok so reset a boolean after n seconds and that will dispose of the modal

nice

this effect was added after I first learned re-frame so it's good to get a chance to use it ::))

thanks @U2FRKM4TW

NP!

Just to exclude the obvious - have you read the official documentation on re-frame's website?

http://day8.github.io/re-frame/re-frame/

I read through this tutorial (same as @U2FRKM4TW is referring to) and really liked it, the concepts are featured prominently

Ok - thanks guys. I started there but I was turned off by the geophysical weather diagrams. 🙂 I'll re-appraoch. Very kind thanks.

Thanks @U2FRKM4TW and @USDPTD3FY for pointing me back there. The docs are indeed very well written. I must just not have been ready in the past.

I would try create an MRE with as little higher abstractions as possible. In the process of coming up with such an MRE, it should become clear where the bug is exactly. Given what you describe, chances are it's a bug in Edge, and it might've even been reported already. Or you might have some Edge extension that likes to rob pages of events.

@U44P1CP5K I agree with what @U2FRKM4TW is saying. Under the hood, re-pressed is a very thin wrapper for goog.events.listen and any issues with keypresses not being listened to are probably upstream of re-pressed.

Got it. Thanks!