Lol no way wait

Had it saved, pressed back and took screenshots haha I think we’re on to something here I’m down to hack on this during the weekend

ta-da https://www.dropbox.com/sh/ln611endzm2v8g0/AABMKZknxOHbqgAej_Rj1RSma?dl=0

Thank you!! And you can find the thread here, too, on the Clojurians Slack archive: https://clojurians-log.clojureverse.org/re-frame/2020-07-26

oh wow I wasnt aware this existed

@U07FP7QJ0 is responsible for the miracle that is the Clojurians Slack Archive! Thanks @U07FP7QJ0! 🙂

As a tip, you can find threads you've participated in near the top of the left sidebar in Slack. They seem to stay there for quite a while!

Ha thanks! @UCW9TUDNK learned something new today

@UCW9TUDNK WOW!!! Thank you! That’s awesome!!!

…and a relief!!!

https://github.com/realgenekim/re-frame-event-graph/blob/master/resources/trello-events.cljs Posted only for your convenience! And thanks again!!!

@mikethompson Your observation about using a state machine(s) is jolting. I can totally see adding one function could take most of the logic out of many of the events. Exciting!

@genekim This is all good. I like seeing how people use re-frame. I'll cycle back later today - morning meetings here

Cool cool. For your amusement, I’ll post a video of the app tomorrow, and maybe I’ll use this as incentive to get all the Trello secrets out of the repo, and publish it. (Something I’ve wanted to do for 4 years. 🙂 (Although it will show everyone to what extent I don’t understand CSS. :rolling_on_the_floor_laughing::rolling_on_the_floor_laughing:

There are only two kinds of people in this world: 1. Those that don't know CSS 2. Those that think they do, except they don't. Not really.

Further Notes: 1. to reduce noise, you should make check-spec-interceptor a global interceptor (a new feature) 2. It appears as if your calls to interfaces/invoke and io/display-notification are side effecting and would ideally be modeled as effects (ie. use reg-fx) 3. In https://github.com/realgenekim/re-frame-event-graph/blob/master/resources/trello-events.cljs#L355-L363 it appears you are using events instead of function calls. IMO, you should have a function call reset-card not an event. This function would be given db arg and return a modified db. Then you simply call that function in that event handler ... don't dispatch an event to do it. Events are meant to model user intent, not model the low level machinery - good old functions calls do that just fine. 4. I'm sure I don't need to tell you that you should clean up all those side effecting dispatch calls in reg-event-db handlers ... but I will any way, just in case :-) BTW, I know I haven't got the the event knot yet. More later when I get a bit more time.

This is mind-expanding. 🤯🤯 Thank you!

This is beautiful…

(>defn reset-card
  [db] [map? => map?]
  (assoc db :current-card-comments []
            :current-card-attachments []
            :new-comment-text ""))

(>defn set-list
  [db list-id] [map? string? => map?]
  (assoc db :selected-list list-id))

(comment
  (-> {:a 1}
      reset-card
      (set-list "abc")))

This is even more beautiful — as imperative stuff moves to more declarative…

(re-frame/reg-event-fx
  ::select-board
  [check-spec-interceptor]
  (fn [{:keys [db]} [_ board-id]]                           ; currstate, and new state
    (println "::select-board: " board-id)
    {:dispatch-n [[::save-and-clear-searchbox]
                  ; if moving card, make sure focus is in search box
                  (when (= (:left-pane-view db) :leftpane-moving-board)
                   (io/focus-searchbox ::focus-searchbox))
                  [::load-board-lists board-id]
                  [::select-board-next-leftpane-state]]
     :db       (dbh/select-board db board-id)}))

Wow, this is nice…. made my first reg-fx.

(re-frame/reg-fx
  :load-lists
  (fn [board-id]
    (check-and-throw string? board-id)
    (println ":load-list: fired off go-routine: board " board-id)
    (interfaces/invoke interfaces/trello {:command :load-lists
                                          :board-id board-id
                                          :callback ::callback-load-board-lists})))

I have to say your use of guardrails and check-and-throw impresses me. In my code those things are nonexistent 😹

Haha — your ability to write and run code without Guardrails and check-and-throw impresses me! Seriously, I pass in wrong stuff all the time, sometimes as an accident or misinterpreting the API. (Just yesterday in my first reg-fx posted above, at first I accidentally passed in [board-id] instead of board-id and would have spent 10+ minutes trying to figure out why I was getting strange behavior or unreadable, long exception.)

I am able to now, but maybe not when touching it again next year. 😅 I do see real value in type signatures as documentation, and wish it was more common to use them in Clojure!