odd little question

on line 10 … I need to fully disambiguate gap …. but only here

@raymcdermott You have gap argument.

I see an error like this in the console

template.cljs?rel=1513207500959:302 Uncaught Error: Assert failed: Invalid Hiccup form: [nil :size "1"]

Look at the second line of your example.

I think it's better to use aliases for namespaces like (require '[re-com.core :as rc]) and then use rc/gap, rc/label etc to avoid errors like this.

ok, so if I use gap in the h-box I’m not allowed to use [gap …]

rc/xxx is a bit uglier but if it works more reliably - fair enough

thanks @p-himik

@raymcdermott just to confirm this is a name shadowing issue, not specific to re-com

re-frame-trace 0.1.14 is out now: https://github.com/Day8/re-frame-trace/releases/tag/0.1.14

And a new demo video: https://github.com/Day8/re-frame-trace#a-visual-sampler

Assuming the ::form-errors? subscription is updated by the ::validate-form dispatch. What is the best way to ensure it is done running before checking the errors and dispatching the ::submit-form?

(defn submit-button []
  [:button#submit-button {:type "submit"
                          :on-click (fn [e]
                                      (rf/dispatch [::validate-form])
                                      (when (not @(rf/subscribe [::form-errors?]))
                                        (rf/dispatch [::submit-form])))}
   "Submit"])

@jarrodctaylor you can use the :dispatch effect that is provided with re-frame from a single form submission event handler

(rf/reg-event-fx
 ::validated-submission
 (fn [{:keys [db]} event-vec]
   (let [errors (do-validation <whatever needed>)]
     (if (empty? errors)
       {:dispatch [::submit-form]}
       {:db (assoc db ::form-errors errors)}))))

and your :on-click is just :on-click (fn [e] (rf/dispatch [::validated-submission]))

Makes sense. Thanks.