Fork me on GitHub
#re-frame
<
2017-11-27
>
v3ga03:11:51

re-frame/bidi people, i’m attempting to use a route in views/celestial.cljs and its telling me :celestial isn’t ISeqable. I’m not sure what I’m missing. I’m sort of going in circles at this point. https://github.com/jamalburgess/d-c/blob/auth/src/cljs/d_c/views/celestial.cljs

danielcompton03:11:29

@decim that error message sounds like you’re giving something a keyword when it expects to get a collection

danielcompton03:11:36

what line is the error coming from?

danielcompton03:11:09

I couldn’t see that keyword used anywhere

v3ga08:11:23

@danielcompton It ended up being my routes were completely jacked up. Somehow I wrote my main routes without putting them in a vector in routes.cljs (def routes [“/” {“” :universe “celestial” :celestial}])

andre08:11:45

hey guys, i have some bounty for re-frisk, so if you have interesting ideas please create an issue, thank you https://github.com/flexsurfer/re-frisk, btw there are 2 open bounties if someone wants to contribute

minikomi11:11:13

Although I had no problems using plain reagent, using re-frame with an input and trying to input Japanese text using an IME is bugging out a bit

minikomi11:11:33

there's a few open React bugs which seem related, but with plain reagent, I wasn't getting the caret-jumping

p-himik12:11:41

@minikomi What versions of Reagent and re-frame are you using?

minikomi12:11:42

I recorded a performance profile which contains a caret-jump -- it(s just after the 10000ms point

minikomi12:11:30

@p-himik In this case it was [re-frame "0.10.3-alpha1"] and [reagent "0.7.0"]

minikomi12:11:05

c-start
core.cljs:163 reframe update value t
core.cljs:163 reframe update value て
core.cljs:163 reframe update value てs
core.cljs:163 c-start
core.cljs:163 reframe update value てsてす
core.cljs:163 reframe update value てsてすt
2core.cljs:163 reframe update value てsてすと
core.cljs:163 c-end

minikomi12:11:47

Interesting. There's an extra on-composition-start event being fired when the caret jumps

minikomi12:11:50

Got to go home, will try to dig in more tomorrow morning and make a proper issue report. From what I can see, it's pretty consistently that when the caret jumps, there's extra onComponentStart events being fired on the re-frame controlled input, but I can't get it to happen on the reagent-only input. If anyone has any ideas to try, add to this thread!

minikomi13:11:38

Re-reading the re-frame source I remembered dispatch-sync existed.. seems it fixes the problem!