Fork me on GitHub
#re-frame
<
2017-11-26
>
rgm01:11:56

@mikethompson thanks, as always, for the hint to go re-read the docs very closely... I sorted it out. Mea derpa. My issue was that I was referring to the props as passed into the outer component function, where the correct reference is to pull them out using (reagent/props comp) ... see https://gist.github.com/rgm/0e75c4bf069a9136e98179d9596c4bae/revisions#diff-38ce895fe7cb920d4738a7556e8ec343R90

rgm01:11:37

so the outer component function simply closed over the original value

rgm02:11:00

hence the breaking of updates when the subscription changed.

stvnmllr203:11:26

Hey all, anyone else have issues with reframe and selenium tests typing too fast? Guessing it could be my logic, as i haven't noticed it in more than one place, but one box that updates db on-change seems to miss letters when selenium tries to type in the box. Just thought I'd ask if I'm the only one who's seen such a thing.

souenzzo10:11:54

R u using dispatch-sync on input's "on-change" ?

stvnmllr203:11:30

I was under the impression that I shouldn't use that. But it would probably help right? Is that idiomatic? I figured I had to improve the rendering time, but yeah, it's pretty fast so even that may not help. Thanks for the input.

souenzzo12:11:34

Not sure if it's idiomatic, but "controled" input will work just with dispatch-sync. In your desktop/small app, may work without sync, but if you have a cheap samsung phone, it will never work without dispatch sync 😛