Fork me on GitHub
#re-frame
<
2017-08-27
>
curlyfry08:08:31

@deg It's an issue with trace. It's been solved recently but a version containing the fix hasn't been released yet.

sandbags13:08:28

esp like subs being more easy to reach

ernestas13:08:38

Can't figure out how to make the body tag to be part of the main view. Is it possible or setAttribute on the body tag is the way to go?

sandbags15:08:47

@ernestas reagent needs something to attach to

ernestas15:08:00

yeah, I've tried wrapping the body in the div and attaching to that, but that's illegal, so I suppose the setAttribute is the only way, no?

sandbags15:08:30

without knowing what you are trying to do, i can't venture an opinion

ernestas15:08:41

to change the class of the body tag

ernestas15:08:52

this is for a modal, to stop body scrolling

sandbags15:08:45

well you can just use JS dom code to do that can't you?

ernestas15:08:03

yes, it works, but doesn't seem very re-framy

sandbags15:08:41

have you had a look at how re-com modals work?

sandbags15:08:48

that'd be where i would start

ernestas15:08:11

I don't think that touches the body. The backdrop should be enough to stop the body scrolling, but bootstrap css v4 also changes the body tag due to having the transitions. I have it working now, so all good. Thanks for the pointers.

akiroz19:08:02

You can do that using interceptors, I wrote a library that could sync your app-db to local-storage transparently using interceptors that messes with the :db (co)fx keys.

gadfly36121:08:16

Need to bump re-frisk version in re-frame-template when i get a chance

andre07:08:14

i'll do it after release