Fork me on GitHub
#re-frame
<
2015-11-25
>
richiardiandrea00:11:05

guys the debugging stuff is top-notch!

richiardiandrea01:11:35

I guess there is nothing I can do, even by debugging, there does not seem to be any issue with re-frame I am just passing from a two-column to a one-column layout and all the buttons are re-drawn..

richiardiandrea01:11:10

but why do they? if the container changes...shouldn't react avoid exactly that? I am still probably looking at some missing reaction optimization

richiardiandrea01:11:30

but now I can debug the events, that's great 😄

richiardiandrea04:11:24

@mikethompson: I was trying to update dynamically the children of an h-box based on a subscription...but the children are props of a h-box so everything was cascading and re-rendering

gabe16:11:53

@mikethompson: are we going to see re-frame updated for the reagent 0.6.0-SNAPSHOT?

gabe16:11:08

I had to make a minor tweak to get it working.

richiardiandrea19:11:02

What is the difference in inlining your children like the following or having the wrapped in a vector?

[v-box
      :size "1 1 auto"
      :gap "2px"
      :children (for [topic (:topics section)]
Let's say I only have children, no other components, are they cached in the same way by React if they are [:div {} here] or [:div {} [here]] ?

danielcompton20:11:14

@gabe: what was the tweak?

gabe20:11:17

change do-later -> do-after-render

gabe20:11:09

w/ the obvious change to :require and reagent version in project.clj

mikethompson21:11:30

@gabe: as far as I know we are on v0.5.0 There's never been a v0.6.0-SNAPSHOT. https://clojars.org/re-frame

gabe21:11:52

@mikethompson: my bad. the snapshot hasn’t been released, but that’s what it’s called in master.

gabe21:11:17

but i guess you don’t want to shoot at a moving target

mikethompson21:11:18

Nothing substantial has been done since v0.5.0. That should be your target

gabe21:11:58

@mikethompson: i think we’re talking past each other. on reagent’s master branch, react dependencies have been updated.

gabe21:11:04

in order to use the newest version of react, changes to reagent were made and those changes will have to be reflected in re-frame.

gabe21:11:30

stupid dependency chains

mikethompson21:11:47

Oh, sorry, now I see. I misread what you asked.

mikethompson21:11:39

yeah, we'll wait for a reagent release candidate before we do anything with re-frame

gabe21:11:03

it’s a minuscule change anyway

gabe21:11:20

great work on the project btw

mikethompson21:11:57

Thanks! We certainly find it nice to use simple_smile

gregg23:11:10

@richiardiandrea: the reason it works as you have the code is because for returns a list, which v-box is happy to accept. When wrapped in a vector, v-box will consider it to be a single component but Reagent will do the unwrapping (I believe)

richiardiandrea23:11:42

I think it is the opposite, lists (and only lists) are squashed inline...by the way in the second case it wants

:key
for each generated child