Fork me on GitHub
#rdf
<
2022-08-02
>
Kelvin21:08:47

@rickmoynihan I finally got around to making a PR to implement protocols for axioms, in order to support the datatype coercion that you’ve been asking for

Kelvin21:08:30

(If only there was an easy way to add people from outside one’s GitHub org as reviewers; otherwise I’d add you as a reviewer directly.)

rickmoynihan23:08:03

OMG!!! This looks fantastic! Thanks 🙇 I’ve skimmed over the PR briefly and made some small comments, but I’ve not had time to look in more depth.

Kelvin14:08:47

Thanks for taking a look! I didn’t see any comments that you left though?

rickmoynihan13:08:09

ahh sorry I’d added them one by one in a review; and forgot to submit it.

rickmoynihan13:08:05

As I said though these are just from skimming over the diffs; and I’d like to find some more time to dig into it. Though It’ll likely be next week before I get to look at it properly.

rickmoynihan13:08:33

generally though I think this looks great! 🙇

Kelvin21:08:56

I responded to the comments that you left. The only one I disagree with was the one about java.util.Date for reasons I explain in my followup, but otherwise I took into account your suggestions.

Kelvin17:08:07

Just added support for OffsetDateTime, ZonedDateTime, LocalDateTime, and their date- and time-only equivalents

👍 1