rdf

Kelvin 2022-08-02T21:48:47.671419Z

@rickmoynihan I finally got around to making a PR to implement protocols for axioms, in order to support the datatype coercion that you’ve been asking for

Kelvin 2022-08-10T17:11:07.064569Z

Just added support for OffsetDateTime, ZonedDateTime, LocalDateTime, and their date- and time-only equivalents

👍 1
2022-08-04T13:47:09.280389Z

ahh sorry I’d added them one by one in a review; and forgot to submit it.

2022-08-04T13:48:05.773199Z

As I said though these are just from skimming over the diffs; and I’d like to find some more time to dig into it. Though It’ll likely be next week before I get to look at it properly.

2022-08-04T13:48:33.781869Z

generally though I think this looks great! 🙇

Kelvin 2022-08-08T21:36:56.628279Z

I responded to the comments that you left. The only one I disagree with was the one about java.util.Date for reasons I explain in my followup, but otherwise I took into account your suggestions.

Kelvin 2022-08-02T21:49:23.629579Z

https://github.com/yetanalytics/flint/pull/27

Kelvin 2022-08-02T21:50:30.998819Z

(If only there was an easy way to add people from outside one’s GitHub org as reviewers; otherwise I’d add you as a reviewer directly.)

2022-08-02T23:17:03.065859Z

OMG!!! This looks fantastic! Thanks 🙇 I’ve skimmed over the PR briefly and made some small comments, but I’ve not had time to look in more depth.

Kelvin 2022-08-03T14:01:47.588519Z

Thanks for taking a look! I didn’t see any comments that you left though?