random

rafaeldelboni 2023-06-21T14:00:45.683629Z

Hey is there anybody from Scarlet Comply here? I would like to talk about a feature request in https://github.com/scarletcomply/license-finder/issues/2. 😬

ericdallo 2023-06-21T14:03:58.884489Z

@domagala.lukas @jacob.maine

2
Lukas Domagala 2023-06-21T14:05:07.291869Z

thanks @ericdallo that's mostly written by @fb

2023-06-21T14:11:48.283259Z

👂

rafaeldelboni 2023-06-21T14:13:25.305749Z

Thanks folks, I created a issue with my suggestion here, I would like if you folks would accept an PR. https://github.com/scarletcomply/license-finder/issues/2

ericdallo 2023-06-21T14:15:12.241999Z

Giving a little bit more context: we are trying to use license-finder in Nubank, but we have hundreds of lein services yet, and license-finder looks pretty promising, with @rafaeldelboni's suggestion, it works great and we think the improvement would fit well in the lib itself :)

rafaeldelboni 2023-06-21T14:16:56.229119Z

Yeah the idea of having a single output format for, lein, deps and shadow-cljs projects is super cool

2023-06-21T14:18:43.216759Z

Hey folks! Thanks for your interest and the suggestion! We do not use Leiningen at Scarlet so there are currently no plans from our side to develop that. Totally open to look at a PR though. @rafaeldelboni seems like you have already a proof of concept using lein2deps?

rafaeldelboni 2023-06-21T14:19:24.786389Z

Yeah, I did a POC this weekend and got really good results with some of your lein projects 🙂

👍 1
2023-06-21T14:20:30.816779Z

If you could open a PR that would be amazing

rafaeldelboni 2023-06-21T14:20:56.093279Z

I will do, thanks for your attention.

2023-06-21T14:21:27.204959Z

Thanks! And sorry for not noticing your issue last week. Forgot to hit that watch button 😅

😬 2
2023-06-22T08:59:54.294039Z

Thanks a lot for the PR @rafaeldelboni — releasing this right now! ❤️

2023-06-22T09:02:08.411379Z

(Well, when Clojars is up again)

😆 1
2023-06-21T14:05:11.920049Z

@fb has joined the channel