Clojurians
#proton
<
2015-12-15
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dvcrn01:12:27

it seems like vim mode plus has a lot more stuff than vim-mode. We can always swap it out later again :simple_smile:

dvcrn01:12:51

Very happy to see all these contributions to proton. So many new things!

sglyon03:12:45

Ready for a bunch more PRs to review?!

sglyon03:12:57

I’ve got 2-3 new layers and a number of other tweaks sitting locally right now

sglyon03:12:08

Just need to find time to polish them up

dvcrn03:12:18

tell me more :stuck_out_tongue:

dvcrn03:12:48

We need to somehow get the space key on non-editor windows working. I think that might be one of the most important parts

sglyon03:12:39

can we not just add it as a atom-workspace keybinding?

dvcrn03:12:47

that's what I'm trying right now

dvcrn03:12:00

ok I have an idea

dvcrn03:12:22

hm so when we bind body or atom-workspace, it would also catch keybindings in insert-mode, which we don't want

dvcrn03:12:28

need to somehow exclude that

sglyon03:12:53

usually I see stuff like this:

sglyon03:12:08

'atom-text-editor.vim-mode:not(.insert-mode)’:

dvcrn03:12:22

so: 1. change logic to append proton-mode class to body / workspace instead 2. make sure the proton:chain triggers correctly 3. make sure it doesn't trigger in text fields and insert mode

sglyon03:12:29

that should work, we just need to figure out what css names vim-plus exports

dvcrn03:12:29

yeah something like this

dvcrn03:12:43

it's the same, just with vim-plus-mode instead of vim-mode

dvcrn03:12:49

going to lunch really fast.

sglyon03:12:52

sounds good

sglyon03:12:59

I’ll probably be up for a while longer

sglyon04:12:31

So I really am not liking vim-mode-plus

sglyon04:12:19

It keeps looking like I’m in visual mode, but it doesn’t recognize it. So when I hit escape nothing happens. The only way I have been able to escape it is to reload the editor window

dvcrn05:12:11

it has a lot more features than vim mode. Stuff like - block selection (ctrl+v) - feedback on copy - instant search results when hitting / (vim mode wants you to hit enter first) - incremental search - smartcases

dvcrn05:12:19

in general vmp seems to be far ahead and more compatible with normal vim

sglyon05:12:33

Too bad it seems buggy

sglyon05:12:34

I’m excited about this, once it is ready: https://github.com/carlosdcastillo/vim-mode

dvcrn05:12:03

that would be amazing

dvcrn05:12:05

neovim all the way

dvcrn05:12:28

can you reproduce that selection bug somehow?

sglyon05:12:39

Not really, it comes up about every 15 minutes though...

sglyon05:12:55

I haven’t been paying enough attention to what I’m doing to figure out what triggers it

sglyon05:12:01

I think it has something to do with scrolling

dvcrn05:12:08

the engineer is super fast in responding

sglyon05:12:29

K, I’ll try to pay better attention so we can file a proper issue for him

dvcrn05:12:48

maybe a optional setting to enable basic vim mode would be nice

dvcrn05:12:09

like vim-mode-provider: :neovim :vim-mode :vim-mode-plus

sglyon05:12:29

I’d like that for the time being. Would that make the other config vars you set harder to work with?

dvcrn05:12:37

hmm not really. We can basically overwrite configs in the init-layer! function by now :simple_smile:

dvcrn05:12:47

luckily we got that working

dvcrn05:12:21

I'll focus on the space everywhere stuff first though. At least when I have some more time :simple_smile:

sglyon05:12:40

Yeah sounds good. I didn’t get around to the other PRs tonight, but maybe tomorrow I can find a few minutes to clean them up

sglyon05:12:03

I’m going to add rust, go, some more toggles, julia-mode keymaps, etc...

dvcrn05:12:16

cool! :+1: