Fork me on GitHub
#portkey
<
2018-09-16
>
baptiste-from-paris13:09:43

I’ll do an update probably at the end of the week with some documentation

viesti17:09:22

Took session token usage to master by cherry-picking from low-conform and did a rebase on master in low-conform. Should have made the change to master in the first place, the large diff that I was looking at was caused by whitespace changes only.

viesti17:09:03

so as a warning, please do git pull --rebase in low-conform branch next time when you pull

viesti18:09:12

This should be #{:v4 :s3v4} I guess?

baptiste-from-paris18:09:26

wait a second I check

baptiste-from-paris18:09:25

(case :a
    (:a :b) true) => true

viesti19:09:35

ah true, just as the docstring says, just haven’t used the (test-constant1 ... test-constantN) result-expr form

baptiste-from-paris19:09:51

So I think I will have time to make some s3 request thiis week as I am now able to make the request components

baptiste-from-paris19:09:27

I was thinking about cleaning up a bit

baptiste-from-paris19:09:03

indeed, I was focusing on the ser/resp part but gen-operation-xml/json/etc are way to complicated right now

baptiste-from-paris19:09:17

And I think I have a way to simplify

baptiste-from-paris19:09:46

my goal is to let you guys take some other stuff to work on and right now it’s to messy

baptiste-from-paris19:09:00

mostly because I was way too focus

baptiste-from-paris19:09:06

sorry about that ^^

baptiste-from-paris19:09:06

@viesti I am not sure if I recall well but I think you once talked about a docker for testing

baptiste-from-paris19:09:40

It would be awesome if we could test most of the sdk(s) for the sake of the project

viesti19:09:25

there are projects for faking aws api’s

baptiste-from-paris19:09:58

what’s your advice on testing apis ?

baptiste-from-paris19:09:09

any idea what we could do ?

viesti19:09:41

thinking that cleaning up (removing unused arguments) and refactoring in the hammock might be option (god hammock time blasphemy :))

viesti19:09:24

haven’t used but could be worth a look

baptiste-from-paris19:09:58

it’s definitly a concern

baptiste-from-paris19:09:17

a little change in gen files can have impact on all apis ^^

viesti19:09:39

I guess I boobytrapped myself by adding x-amz-security-token

viesti19:09:46

talking about tests…

viesti19:09:14

anyway, tests with localstack fixture (such that one can run test body against a running localstack in the repl) might be neat

viesti19:09:17

but sleep now