Fork me on GitHub
#portal
<
2023-10-18
>
JAtkins03:10:38

super simple test runner I've started using: https://github.com/JJ-Atkinson/portal-test-reporter/commits/master I've bound it to a repl command, and (run-test {} \*ns\*) works great with intellij change repl ns .

awesome 1
lukasz15:10:00

Really cool, I started writing something like this for Kaocha

💯 1
djblue02:10:10

I feel like I just added the source-location viewer, it's cool to see it getting usage here! It looks like you made really good use of the hiccup + portal viewers in general in your implementation 👏

djblue02:10:19

Our of curiosity, how did you go about building this / finding out all the Portal bits you needed to know to get this working?

JAtkins03:10:43

In terms of...? Presumably the hiccup support for nested viewers? I saw hiccup support and figured "If I implemented this, I'd have made a way to nest custom viewers in it". Since I didn't see it mentioned in the docs I went to the hiccup viewer source and read what it does 😂. Found a couple usages in the cljdoc viewer. While looking at the clj doc viewer I realized it's what rendered the help system, and looking at that I found example usages for the source location viewer and relative time viewer.

👍 1
djblue03:10:19

Yeah, I think the hiccup nested viewer thing may only be mentioned in https://cljdoc.org/d/djblue/portal/0.48.0/doc/guides/default-viewer 😂 It might also be good idea to have a guide dedicated to it directly 👌

djblue03:10:29

Any suggestions for what else may have made finding things easier?

JAtkins03:10:57

Mention really high up in the readme the portal/doc function, and 1. say that it's not the same as the cljdoc wiki, and 2. it shows examples of existing custom viewers. That would help alot 🙂

🙏 1
JAtkins03:10:56

maybe add a oneliner clj -A .. -X that launches the doc page would be great too

👍 1
djblue03:10:45

I probably won't be able to get to it for a bit. If you feel up to it, a PR would be awesome 👌

👍 1